This allows users to clone existing product variations in drupal commerce so the need to create completely new ones even if they are similar no longer exists. It drastically helps improve the user experience as well as speeds up the process of adding new product variations into the system. I created it because there wasn't any other modules that did the same thing although one did come close it did not work for the kickstarter distribution. I wanted to promote it as there are a number of people already using the sandboxed version and it would be better if it was a full project I feel.

https://drupal.org/sandbox/Daemon_Byte/2031677
git.drupal.org:sandbox/Daemon_Byte/2031677.git

Comments

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxDaemon_Byte2031677git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

garnett2125’s picture

garnett2125 commented

Hi,

Manual review :

  • You should review your line indentation :https://drupal.org/coding-standards#indenting and the drupal coding standard in general.
  • commerce_clone_product_varaiation.module Line 38 : commerce_product_ui_product_type_form_validate function doesn't return anything and yet you return what it's returning.

=)

Daemon_Byte’s picture

Daemon_Byte commented

And why does it matter if the function currently returns nothing? If that function returns nothing then I want to return nothing ergo it is doing exactly what I want it to do. If in the future that function (which is in code outside my control) should change then my function will remain valid because it will still be returning exactly what I want it to return. As for the tab spacing, I guess when I wrote the module I was using standard settings for work instead of drupal ones and didn't notice.

Daemon_Byte’s picture

Daemon_Byte commented
Status: Needs work » Needs review

branch 7.x-1.x has the spaces converted from 4 to 2.

andyd328’s picture

andyd328
he/him/his
Primary language English
Location Lyttelton, NZ 🇳🇿
commented

Hi,

I installed onto a clean Commerce Kickstart site with the demo products. It worked perfectly, no issues at all.

There needs to be a Readme file, along with some basic usage instructions on the project page. It's a very simple module to use, but it should really be there anyway. There's also a total lack of comments in the .module file.

I look forward to using your module :)

tibezh’s picture

tibezh commented
Status: Needs review » Needs work

Hi

Code too short
This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.
README.txt
Please take a moment to make your README.txt follow the guidelines for in-project documentation.
Major coding standards / best practice issues
An automated review of your project has found some issues with your code; As coding standards make sure projects are coded in a consistent style we please you to have a look at the report and try to fix them. Anyway, note that issues found are possibly false positives and fixing all issues is not a requirement for getting through the application process.

You can find the results of the automated report at http://pareview.sh/pareview/httpgitdrupalorgsandboxdaemonbyte2031677git.

Kind regards

Daemon_Byte’s picture

Daemon_Byte commented
Status: Needs work » Needs review

I'm fine with that. I have this module that I just wanted to get out there because people seemed to need it like I did. I already have another module that I'm starting to maintain so I don't need git access. I believe I have addressed the issues mentioned above now.

On a side note is it possible to use that website to test my own modules so I don't have to do the torturous tennis game over every tiny rule and if so how?

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Needs review » Needs work

@Daemon_Byte - just go to pareview.sh and paste your git url in the "Review a branch" textbox, and you'll get the same report. In your case it's "http://git.drupal.org/sandbox/Daemon_Byte/2031677.git".

You should remove the master branch, and rename "7.x-1.x-dev" to just "7.x-1.x". You can make a -dev release later once the project is approved.
http://pareview.sh/pareview/httpgitdrupalorgsandboxdaemonbyte2031677git still complains about the comment formatting mostly.

Setting to "needs work" for the branch problems, but otherwise this is RTBC from me.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Daemon_Byte’s picture

Daemon_Byte commented
Status: Needs work » Reviewed & tested by the community

That bunch of loops is jumped. Much easier when you can actually run the check yourself :)

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented

Yup, RTBC from me.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

It's been a month without any problems reported, so I'm promoting this myself as per https://drupal.org/node/1125818.

Thanks for your contribution, Daemon_Byte!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.