Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
31 Jul 2013 at 16:07 UTC
Updated:
12 Oct 2013 at 04:24 UTC
This is my first module.
Please check it.
https://drupal.org/sandbox/AndreaPerdicchia/2054733
istruction for git:
git clone AndreaPerdicchia@git.drupal.org:sandbox/AndreaPerdicchia/2054733.git webform_gmap
Use gmap and webform module
Configure gmap module with your key.
Comments
Comment #1
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxAndreaPerdicchia20547...
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
vwX commentedI received a password prompt from your git clone link. Should be
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/AndreaPerdicchia/2054733.git _d7__webform_gmap_and_location
Comment #3
vwX commentedLooks like there is a 6.x module with similar goals: https://drupal.org/project/webform_gmap Have you looked at helping and upgrading this module? On second look, it looks like that is what you are trying to do.
I enabled your module with no issues, but could not get it to work. Your instructions are not clear to me.
I looked at your module code and see very little code in it, most code is in your gmap.inc file. Lots of commented out code.
I'm leaving this at "needs work."
Comment #4
AndreaPerdicchia commentedI started from https://drupal.org/project/webform_gmap but i've added a lot of functionality.
For work this module you must
1. configure the gmap module.
2. add field address, locality, postalcode ecc..
3. in webform gmap module configure and set the key of textfield at 2. (address, locality, postcode ecc...)
If is not again clear, i try to post a video.
A Lots o commented code is for future use.
Comment #5
klausiThis sounds like a feature that should live in the existing webform_gmap project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the webform_gmap issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.
If that fails for whatever reason please get back to us and set this back to "needs review".
Comment #6
PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #6.0
PA robot commentedDelete master branch