[D7] Commerce Dunning

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Manual Review, Looks good code wise. Hopefully on of the commerce experts will chime in on this one.

I think you should add the argument information to your last function in commerce_dunning.module. I have a patch with my suggestion, but you're going to probably want to add more about the $order_id and exactly what that is.

Looks good and works fine !

@asherry: This is not a coding standard and the parameters don't need to be fully documented (unless they are on a class).

I like a module where the lines of test code outnumber the lines in the main module by 5:1 =)

I just caught a couple super nit-picky text and punctuation changes.

As for the commerce standpoint, this was architected and reviewed by several members of the Commerce Guys team with the intention of using it internally on our own web sites. As Product Owner of this I can attest that the use case is valid and reflects a lot of careful thought on Bálint's part as well as others.

This looks great to me, no issues found everything looks well written. Nice tests too!

Thanks for your contribution, balintk!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.