Provide an alias for 'plugin.manager.entity' called 'entity.manager'

+++ b/core/core.services.ymlundefined
@@ -160,6 +160,8 @@ services:
+  entity_manager:
+    alias: plugin.manager.entity

I would switch these round. /me hides

Sorry, I still think this should be switched round, all other plugin managers are plugin.manager.xx, so I think entity manager should still have this as its primary, with 'entity.manager' as the alias.

#4, #3 does what you ask. I'll update the summary.

updated

No, #3 adds plugin.manager.entity as the alias?

The one with the definition is the canonical one. That is still 'plugin.manager.entity'.
#3 adds a new service ID called 'entity.manager' that is an alias for 'plugin.manager.entity'.

See http://symfony.com/doc/current/components/dependency_injection/advanced...., the one with "alias: " is the alias.

Yep, you're totally right, sorry! I was looking at the patch on my mobile, which turns out doesn't help that much.

#3: drupal-2057869-3.patch queued for re-testing.

+++ b/core/modules/system/lib/Drupal/system/Tests/Entity/EntityManagerTest.php
@@ -28,6 +28,7 @@ public static function getInfo() {
+    $this->assertEqual(spl_object_hash($entity_manager), spl_object_hash($this->container->get('entity.manager')));

Always like an spl_object_hash() comparison :)

Looks good, small and simple enough, and has test coverage!

Needs a reroll

git ac https://drupal.org/files/drupal-2057869-3.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1564  100  1564    0     0   1600      0 --:--:-- --:--:-- --:--:--  2012
error: patch failed: core/core.services.yml:160
error: core/core.services.yml: patch does not apply

Reroll.

Committed 8c23138 and pushed to 8.x. Thanks!

Should 'entity.manager' be the recommended way to access it?

Very much +1.
(copy/paste my usual rant that the EntityManager isn't a plugin manager)

Patch doesn't apply anymore.

Yay.

Yet again...

git ac https://drupal.org/files/entity_manager-2057869-23.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  107k  100  107k    0     0  55035      0  0:00:01  0:00:01 --:--:-- 60379
error: patch failed: core/modules/field_ui/lib/Drupal/field_ui/Form/FieldInstanceEditForm.php:72
error: core/modules/field_ui/lib/Drupal/field_ui/Form/FieldInstanceEditForm.php: patch does not apply

:-)

Tagging. To avoid further rerolls.

Well the tag didn't get added and we need another reroll...

git ac https://drupal.org/files/entity_manager-2057869-26.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  106k  100  106k    0     0  49072      0  0:00:02  0:00:02 --:--:-- 53343
error: core/modules/layout/tests/layout_test/lib/Drupal/layout_test/Controller/LayoutTestController.php: does not exist in index
error: patch failed: core/modules/views_ui/lib/Drupal/views_ui/Controller/ViewsUIController.php:69
error: core/modules/views_ui/lib/Drupal/views_ui/Controller/ViewsUIController.php: patch does not apply

RTBC if green.

+ 1, for the 10th time :)

Needs a reroll

git ac https://drupal.org/files/entity_manager-2057869-31.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  106k  100  106k    0     0  55838      0  0:00:01  0:00:01 --:--:-- 61555
error: patch failed: core/modules/field_ui/lib/Drupal/field_ui/FieldListController.php:88
error: core/modules/field_ui/lib/Drupal/field_ui/FieldListController.php: patch does not apply
error: patch failed: core/modules/views/lib/Drupal/views/Views.php:85
error: core/modules/views/lib/Drupal/views/Views.php: patch does not apply
error: patch failed: core/modules/views/tests/Drupal/views/Tests/ViewsTest.php:50
error: core/modules/views/tests/Drupal/views/Tests/ViewsTest.php: patch does not apply

And back to RTBC.

Committed 7742cc3 and pushed to 8.x. Thanks!

This needs follow-up patch

Not in this issue, look at the title.

Filed follow-up #2078847: Clean-up the rest of 'plugin.manager.entity' to 'entity.manager'

Perfect.

I have created #2084279: Remove plugin.manager.entity service in favor of entity.manager.