[D7] Distributor Map

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxElavarasanrks2055469git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello,

[manual review]
distributor_map.module: On lines 112, 133, 277, 281, 286 use t() (excluding html tags.)
distributor_map.module:286 spelling mistake, should be "Cancel"

distributor_map.module:241 Never put variables directly into an SQL query. Always use parameter substitution. https://api.drupal.org/api/drupal/includes!database!database.inc/function/db_query/7

Hi,

Manual review :

1. In 'distributor_map_form', please make use of l() instead of constructing the link.
2. Place your image in a images folder and js in a js folder. This will reduce the complexity structure in your module.

Thank you

Those minor points are surely not application blockers, anything else you found?

@Klausi : Now I found this module working perfectly, just wanted to mention the changes that I felt.

function distributor_map_form_alter() is really confusing.
You should render HTML using Drupal's theme layer. Adding everything in the form's code is very difficult to read/modify.

function distributor_map_block_view() has the same problem.

How this module is different from **many** mapping solutions available on Drupal?
How displaying x y position will help users?

As I said, there are many Drupal projects to handle mapping. Many of them already allow this feature of selecting and saving a location by clicking on the map at the node edit form.

Just getting a module name which focus a niche does not make it different from others.

I think this is a duplicated module, unless the author show the differences from other solutions already available. Feel free to change the issue status and post your arguments if you believe it is really a different project.

@Elavarasan you talked again about what your project does, you did not explain how your project is different from MANY other mapping solutions.

Everything your module does I see other full projects already doing. For example, a very simple project that allows clicking on the map to get the coordinates is gmap. Different than your project, gmap does not uses a static image for the map and it does not use pixels as coordinates. Using pixels as coordinates makes absolutely no sense as it is your own hard-coded image of the world that cannot be changed. I mean, these coordinates makes sense only in your own image, while gmap uses standard latitude longitude coordinates to do exactly the same task in a meaningful way.

Another solution is staticmap module which automatically generates the map from geofield and does not use a hard-coded map image, integrating with Google Maps and OpenStreetMap. Again, there are many other solutions doing the same thing.

Besides gmap there are many other mapping solutions available for Drupal. All top mapping developers* from the community agree there are too many modules to do the same thing already and these solutions are many times just repeating code. The efforts now are to consolidate the shared code among these many different projects into a main API which will be later used by other mapping sulutions (including simple and also very customizable solutions).

*When I say all top mapping developers I include in this list:
Pol - today's maintainer of OpenLayers module
brandonian - mantainer of geofield, geocoder, staticmap, and many others
RdeBoer - maintainer of "IP Geolocation Views & Maps", Leaflet More Maps, Leaflet Markercluster, co-maintainer of Leaflet module.
dasjo - maintainer of geocluster, leaflet_geojson, and others.
zzolo - top contributor of OpenLayers module
nod_ - core contributor and top contributor of OpenLayers module

How you can help:

All these developers are willing to get their projects bases on an common map API, which will be ported to D8 as soon as both this API and Drupal 8 get more stable.

We have been talking at IRC #drupal-geo and also at Location and Mapping group.

The API we are discussing and developing is Mapping module. There is also a sub-module in development: Mapping Leaflet. Pol said he is interested in getting OpenLayers as a dependency of Mapping, too. We want many others to join us.

I invite you to join us on discussions how to improve the Drupal mapping modules, and also helping us fixing this mess we have today of many different mapping modules having duplicated code. Having too many projects doing the same thing is confusing for developers and site builders. The proposal is to have a main API we can trust and many module that will integrate with different map libraries or functionalisties plugins.

This application has never been approved, so changing its status to Fixed was wrong. As now there is a new application from the same user, I am closing this application as duplicate of the new one.