Updated: Comment #6

Problem/Motivation

HEAD is constantly changing, we need to try to keep up with it.
Changes related to TestSwarm:

Proposed resolution

Post your related patches here!

Remaining tasks

/

User interface changes

/

API changes

/

/

Original report by @kevee

The 'account' property was changed to '_account' for getting currently logged in user.

CommentFileSizeAuthor
#8 testswarm-chasing-head-8.patch6.19 KBjelle_s
#6 testswarm-chasing-head-5.patch5.58 KBjelle_s
#5 2097437-1-user-view-multiple.patch546 bytesjelle_s
#3 testswarm-chasing-head.patch5.22 KBseutje
#1 testswarm_current_user_account_2058441_1.patch1.52 KBAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new testswarm_current_user_account_2058441_1.patch1.52 KB

Patch

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review

Changing status

seutje’s picture

seutje commented
Title: Changes (again) to getting current user via request session » Chasing HEAD
StatusFileSize
new testswarm-chasing-head.patch5.22 KB

More changes, like getting the VERSION constant.

not too sure about the $rowdata->result = ((int)$rowdata->failed < 1) ? 1 : 0; though

Status: Needs review » Needs work

The last submitted patch, testswarm-chasing-head.patch, failed testing.

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented
StatusFileSize
new 2097437-1-user-view-multiple.patch546 bytes

@seutje: if you need this in the session, this patch should pass the php tests ;-)

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs work » Needs review
StatusFileSize
new testswarm-chasing-head-5.patch5.58 KB

argh totally wrong patch... again:

Status: Needs review » Needs work

The last submitted patch, testswarm-chasing-head-5.patch, failed testing.

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented
Issue summary: View changes

Updates issue summary

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented
Issue summary: View changes

Updated issue summary.

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented
StatusFileSize
new testswarm-chasing-head-8.patch6.19 KB

Ok, this time for real (I hope). Drupal\system\SystemConfigFormBase was moved to Drupal\Core\Form\ConfigFormBase.

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs work » Needs review
jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented

Patch from #8 committed to latest dev.

Still some work left to do (see the issue summary).

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented
Issue summary: View changes

Updated issue summary.

mgifford’s picture

mgifford
he/him
Primary language English
commented

So both:
Guzzle HTTP client library added to replace drupal_http_request() - https://drupal.org/node/1862446

and

hook_menu() has been replaced by new routing system (and others) - https://drupal.org/node/1800686

Still need to be addressed, right?

mgifford’s picture

mgifford
he/him
Primary language English
commented

8: testswarm-chasing-head-8.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 8: testswarm-chasing-head-8.patch, failed testing.