This issue will list all futures of the version 2

Initial features :

  • Total comparaison (quantity and amount) now can be done by term(s) and/or by product type.
  • Terms selection is done by ajax.
  • These conditions have been renamed to Total amount of selected products comparison and Total quantity of selected products comparison.
  • Line item product has term has been merged into Line item product has terms too.

Comments

MarcElbichon’s picture

MarcElbichon commented

New changes :

  • Added product_display term search to search terms in product_display rather than in products.
  • Referenced field has been replaced by vocabulary name so any product or content-type with a field referencing this vocabulary will be searched.

Need upgrade of your rules.

timlie’s picture

timlie commented

I get following errors with the new functionality (Added product_display term search to search terms in product_display rather than in products):

Notice: Undefined index: context in commerce_rules_extra_node_from_line_item() (rule 29 sites\all\modules\commerce_rules_extra\includes\actions\commerce_rules_extra_node_from_line_item.inc).
Notice: Trying to get property of non-object in commerce_rules_extra_rules_condition_has_terms() (rule 104 sites\all\modules\commerce_rules_extra\includes\conditions\commerce_rules_extra_rules_condition_has_terms.inc).

Condition does not work.

Any solutions?

MarcElbichon’s picture

MarcElbichon commented

Do you use commerce product bundle ?
If so, have a look to #2083307: Line-item->data context not saved to line-item. Causes Rules action 'Get the referencing node from the line item' to fail.

MarcElbichon’s picture

MarcElbichon commented

New features :

  • Change terms operator to select list with Is one of, is all of, is any of, is empty, is not empty operators
  • Add a new parameter to "Quantity of line item has changed" with the quantity of line item before changes
  • Add a new fied Total quantity to commerce_order with the total quantity of the order, available in any data selector
jon pollard’s picture

jon pollard commented

Hi, I am also getting an error when trying to apply discounts to a taxonomy of the product display here is the error:

    Notice: Undefined index: context in commerce_rules_extra_node_from_line_item() (line 29 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/actions/commerce_rules_extra_node_from_line_item.inc).
    Notice: Trying to get property of non-object in commerce_rules_extra_rules_condition_has_terms() (line 126 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/conditions/commerce_rules_extra_rules_condition_has_terms.inc).
    Notice: Undefined index: context in commerce_rules_extra_node_from_line_item() (line 29 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/actions/commerce_rules_extra_node_from_line_item.inc).
    Notice: Trying to get property of non-object in commerce_rules_extra_rules_condition_has_terms() (line 126 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/conditions/commerce_rules_extra_rules_condition_has_terms.inc).
    Notice: Undefined index: context in commerce_rules_extra_node_from_line_item() (line 29 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/actions/commerce_rules_extra_node_from_line_item.inc).
    Notice: Trying to get property of non-object in commerce_rules_extra_rules_condition_has_terms() (line 126 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/conditions/commerce_rules_extra_rules_condition_has_terms.inc).
    Notice: Undefined index: context in commerce_rules_extra_node_from_line_item() (line 29 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/actions/commerce_rules_extra_node_from_line_item.inc).
    Notice: Trying to get property of non-object in commerce_rules_extra_rules_condition_has_terms() (line 126 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/conditions/commerce_rules_extra_rules_condition_has_terms.inc).
    Notice: Undefined index: context in commerce_rules_extra_node_from_line_item() (line 29 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/actions/commerce_rules_extra_node_from_line_item.inc).
    Notice: Trying to get property of non-object in commerce_rules_extra_rules_condition_has_terms() (line 126 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/conditions/commerce_rules_extra_rules_condition_has_terms.inc).
    Notice: Undefined index: context in commerce_rules_extra_node_from_line_item() (line 29 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/actions/commerce_rules_extra_node_from_line_item.inc).
    Notice: Trying to get property of non-object in commerce_rules_extra_rules_condition_has_terms() (line 126 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/conditions/commerce_rules_extra_rules_condition_has_terms.inc).
    Notice: Undefined index: context in commerce_rules_extra_node_from_line_item() (line 29 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/actions/commerce_rules_extra_node_from_line_item.inc).
    Notice: Trying to get property of non-object in commerce_rules_extra_rules_condition_has_terms() (line 126 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/conditions/commerce_rules_extra_rules_condition_has_terms.inc).
    Notice: Undefined index: context in commerce_rules_extra_node_from_line_item() (line 29 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/actions/commerce_rules_extra_node_from_line_item.inc).
    Notice: Trying to get property of non-object in commerce_rules_extra_rules_condition_has_terms() (line 126 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/conditions/commerce_rules_extra_rules_condition_has_terms.inc).
    Notice: Undefined index: context in commerce_rules_extra_node_from_line_item() (line 29 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/actions/commerce_rules_extra_node_from_line_item.inc).
    Notice: Trying to get property of non-object in commerce_rules_extra_rules_condition_has_terms() (line 126 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/conditions/commerce_rules_extra_rules_condition_has_terms.inc).
    Notice: Undefined index: context in commerce_rules_extra_node_from_line_item() (line 29 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/actions/commerce_rules_extra_node_from_line_item.inc).
    Notice: Trying to get property of non-object in commerce_rules_extra_rules_condition_has_terms() (line 126 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/conditions/commerce_rules_extra_rules_condition_has_terms.inc).
    Notice: Undefined index: context in commerce_rules_extra_node_from_line_item() (line 29 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/actions/commerce_rules_extra_node_from_line_item.inc).
    Notice: Trying to get property of non-object in commerce_rules_extra_rules_condition_has_terms() (line 126 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/conditions/commerce_rules_extra_rules_condition_has_terms.inc).
    Notice: Undefined index: context in commerce_rules_extra_node_from_line_item() (line 29 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/actions/commerce_rules_extra_node_from_line_item.inc).
    Notice: Trying to get property of non-object in commerce_rules_extra_rules_condition_has_terms() (line 126 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/conditions/commerce_rules_extra_rules_condition_has_terms.inc).
    Notice: Undefined index: context in commerce_rules_extra_node_from_line_item() (line 29 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/actions/commerce_rules_extra_node_from_line_item.inc).
    Notice: Trying to get property of non-object in commerce_rules_extra_rules_condition_has_terms() (line 126 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/conditions/commerce_rules_extra_rules_condition_has_terms.inc).
    Notice: Undefined index: context in commerce_rules_extra_node_from_line_item() (line 29 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/actions/commerce_rules_extra_node_from_line_item.inc).
    Notice: Trying to get property of non-object in commerce_rules_extra_rules_condition_has_terms() (line 126 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/conditions/commerce_rules_extra_rules_condition_has_terms.inc).
    Notice: Undefined index: context in commerce_rules_extra_node_from_line_item() (line 29 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/actions/commerce_rules_extra_node_from_line_item.inc).
    Notice: Trying to get property of non-object in commerce_rules_extra_rules_condition_has_terms() (line 126 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/conditions/commerce_rules_extra_rules_condition_has_terms.inc).
    Notice: Undefined index: context in commerce_rules_extra_node_from_line_item() (line 29 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/actions/commerce_rules_extra_node_from_line_item.inc).
    Notice: Trying to get property of non-object in commerce_rules_extra_rules_condition_has_terms() (line 126 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/conditions/commerce_rules_extra_rules_condition_has_terms.inc).
    Notice: Undefined index: context in commerce_rules_extra_node_from_line_item() (line 29 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/actions/commerce_rules_extra_node_from_line_item.inc).
    Notice: Trying to get property of non-object in commerce_rules_extra_rules_condition_has_terms() (line 126 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/conditions/commerce_rules_extra_rules_condition_has_terms.inc).
    Notice: Undefined index: context in commerce_rules_extra_node_from_line_item() (line 29 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/actions/commerce_rules_extra_node_from_line_item.inc).
    Notice: Trying to get property of non-object in commerce_rules_extra_rules_condition_has_terms() (line 126 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/conditions/commerce_rules_extra_rules_condition_has_terms.inc).
    Notice: Undefined index: context in commerce_rules_extra_node_from_line_item() (line 29 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/actions/commerce_rules_extra_node_from_line_item.inc).
    Notice: Trying to get property of non-object in commerce_rules_extra_rules_condition_has_terms() (line 126 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/conditions/commerce_rules_extra_rules_condition_has_terms.inc).
    Notice: Undefined index: context in commerce_rules_extra_node_from_line_item() (line 29 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/actions/commerce_rules_extra_node_from_line_item.inc).
    Notice: Trying to get property of non-object in commerce_rules_extra_rules_condition_has_terms() (line 126 of /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/conditions/commerce_rules_extra_rules_condition_has_terms.inc).

It's a shame this doesn't work as this is killer functionality!

MarcElbichon’s picture

MarcElbichon commented

Have a look to #2127567: Get referenced node undefined index

jon pollard’s picture

jon pollard commented

I had seen that issue, it forwards to this issue, which is an issue for "product commerce bundle" - a module which I am not using.

https://drupal.org/node/2083307

To try and debug this I set up a fresh Commerce Kickstart install and I am getting the same error. Maybe this is an issue with something else running in kickstart?

MarcElbichon’s picture

MarcElbichon commented

Can you open a new issue for this ?
Can you print_r($line_item) just before line 29 in /var/www/commerce-kickstart/sites/all/modules/commerce_rules_extra/includes/conditions/commerce_rules_extra_rules_condition_has_terms.inc ?

perignon’s picture

perignon commented
Assigned: Unassigned » perignon
Issue summary: View changes

Version 2.x will be out in beta soon. Refactoring all the code at the moment plus running through as much testing as possible.

perignon’s picture

perignon commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.