I believe the issue #1514406: Images display in the wrong size. was committed too hastily. My image file entities have several fields attached to them which were previously rendered in the colorbox modal. Now all image colorbox links go directly to the image and I miss out on all the other fields.

Comments

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

Thanks for the report mstrelan, I'm looking into it now. Seems easy enough to reproduce.

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented
Priority: Normal » Critical
greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

I've confirmed this is not user error. I cannot get file fields to display either. I've also noticed that the media colorbox view mode in the default file display does nothing and you need to add an image view mode to the default display to get the image to display.

The release applies 4 inter-related patches, I'm experimenting now. If someone has more media experience than I can take a look that would be great.

mstrelan’s picture

mstrelan commented

The issue is probably not really related to the media module, it's more that the colorbox is loading HTML, and the js doesn't known how to automatically resize HTML. This is worsened by the fact that often images in the colorbox will be using an image(cache) preset and therefore may not exist when the colorbox is first loaded. Even if it does exist it seems you get varying results depending on whether the browser has cached the image or not.

It seems to me we need to somehow force the browser to download the image before the colorbox is initiated. Either that or work out how to display the additional fields in the caption area of the colorbox.

My current workaround is to bind to cbox_complete, set a 500ms timer to allow for the image to download and then see if the colorbox can be resized. It's a bit jumpy as sometimes the colorbox resizes twice, I wonder if there is a better approach..

(function ($, Drupal, window, document, undefined) {
  Drupal.behaviors.colorboxTweaks = {
    attach: function (context, settings) {

      if (!$.isFunction($.colorbox)) {
        return;
      }

      $(document).bind('cbox_complete', function() {
        // New images in iframes don't have height initially ... this aims to
        // solve that.
        resizeTimer = setTimeout(function() {
          var windowHeight = window.innerHeight ? window.innerHeight : $(window).height();
          var contentHeight = $('#cboxLoadedContent').find('>:first-child').height();
          var cboxViewportHeight = $('#cboxLoadedContent').height();
          if (cboxViewportHeight < windowHeight) {
            if (windowHeight < (contentHeight + 30)) {
              $.colorbox.resize({height: windowHeight})
            }
            else {
              if (contentHeight > cboxViewportHeight) {
                $.colorbox.resize({innerHeight: contentHeight + 40})
              }
            }
          }
        }, 500);
      });

    }
  };
})(jQuery, Drupal, this, this.document);
mstrelan’s picture

mstrelan commented

I wonder if this jquery library helps - https://github.com/desandro/imagesloaded

dave bruns’s picture

dave bruns commented
Version: 7.x-1.x-dev » 7.x-1.0-rc4

I was hoping to use media colorbox as a way to provide colorbox support to node gallery images (https://drupal.org/project/node_gallery). With just brief testing, I can easily get images to open in colorbox, but I can't get captions to work ( see issue here over at node_gallery: https://drupal.org/node/1913810)

Just to confirm, is this issue (2060073) the cause? Or should I be able to get captions to work with media colorbox?

Thank you for a useful module!

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

Captions work in the dev release. Also hover captions work in the latest media stable without media colorbox.

dave bruns’s picture

dave bruns commented

Greg - thanks for the reply. The readme is truncated in the Colorbox Captions section. At admin/config/media/file-types, what is it that needs to be done to enable captions?

Sorry if I'm missing something basic.

I'm actually not using media at all at this point. I just need a way to use colorbox with node gallery. I don't think media is required?

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

Hi Dave, I'm a new maintainer of this module. I was not aware that this module worked with node gallery.

The Node Gallery module allows you to create multimedia galleries where both the galleries and the gallery items are nodes. (as opposed to gallery items being file fields, like Media Gallery)

Since you are not using media, you can use the colorbox module on nodes. I'm sure there's integration with the node gallery module.

~Greg

durum’s picture

durum commented
Issue summary: View changes

Is there any update on this?

Right now fields from files of type video are displayed. But fields from images are not displayed where the file template is not used and only a direct link to image itself is being generated.

I wonder if I am doing a configuration error or is that part of the code not yet fixed? If the latter; can this be done without configuration through the admin interface, but by creating a image file template and manually printing the colorbox links in the template file.

durum’s picture

durum commented

A quick debug reveals that under theme_media_colorbox() the section below causes this behaviour:

if ($file->type=='image'){
      $variables['path'] = file_create_url($file->uri);
    }

Commenting this out that part in mytheme_media_colorbox() forces images also open in selected view mode.

But now the image in this tpl file is being resized to fit the initial length/height settings from colorbox configuration page. (By videos they have default bigger size from file formatter settings and they can even be maximized with fitvids.)