[D7] Instagram Feeds

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxvaza182060229git

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

Manual review
- Please change git command in issue summary by
git clone http://git.drupal.org/sandbox/vaza18/2060229.git instagram_feeds
- After "drush en instagram_feeds -y", I had this error:
No release history was found for the requested project (api_tokens).
Module instagram_feeds cannot be enabled because it depends on the following modules which could not be found: api_tokens.
-> You must add informations about that. I can't enable your module.

Bye,

API Tokens module has not been released yet.
Module's code can be found here.

Hi vaza18!

Huston, we have problems =)

• In REQUIREMENTS are no all dependencies modules and not specified feature.
• Instagram_feeds.install (20, 50, 60) - you may use function l() with plasecholders to add link
• Instagram_feeds.admin.inc (116) Do not use concatenation. Use one function t()
• Instagram_feeds.module function instagram_feeds_get_tasks not have comments to code

• README.txt

  Please take a moment to make your README.txt to instagram_feeds_moderation module follow the guidelines for in-project documentation.

• Need add the REQUIREMENTS to README.txt in instagram_feeds_plugins module.
• Need add function t() to instagram_feeds_plugins module in (24-26)

Kind regards, tibezh.

• You might want to mention on the project page that this is a Feature module, not a standard drupal module.
• Why do you need to set the schema_version during install? Is this leftover code from development?
• Changing cron settings seems dubious as well - why is a 15 minute cron required? This sounds more like a specific client requirement.
• I'm not a big fan of $l = LANGUAGE_NONE;. I guess you wanted to save some typing in exchange for making the code less clear?

Mostly seems like a really cool module.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Thanks for those updates!

----
Top Shelf Modules - Crafted, Curated, Contributed.

It's been a month without any problems reported, so I'm promoting this myself as per https://drupal.org/node/1125818.

Thanks for your contribution, vaza18!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.