[D7] Justuno Social & Email Lead Generation

Hello,

1) You should remove the git master branch. See https://drupal.org/empty-git-master for instructions.

2) Where's the module ?!?

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxjustuno2061201git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Cleaning up project application titles.

1. What the purpose of the justuno_social___email_lead_generation.info file? There should be one .info file per module.
2. Your working branch should be named 7.x-1.x instead 7.x-7.x.
3. There should be no .php files in the module folder. Please rename it into .inc.

It can take a while, everyone in this queue is a volunteer, please be patient. 1-3 months is very common before an application is finally approved. The best thing you can do is get a Review Bonus by reviewing other applications. That will get you to the top of the list of projects to get reviewed (and hopefully approved). Only manual reviews count, just using http://pareview.sh is not enough.

After 2 weeks of no review, you can bump the priority up again.
----
Top Shelf Modules - Crafted, Curated, Contributed.

• Instead of including your access class on every page request with include_once dirname(__FILE__) . '/JustunoAccess.inc';, just load it from the functions where it's being used.
• Is JUSTUNO_KEY supposed to be the same for all users? That seems odd.
• You seem to be using the database table to keep 1 row of configuration. Instead, you should switch to variable_get/set functions which are designed just for this purpose. You can even use system_settings_form() to render your form, and Drupal will save them for you automatically. You can still verify that they're values in a validate function.
• If curl is required, please implements a hook_requirements() in your install file.
• You have 2 unused variables reported here: http://pareview.sh/pareview/httpgitdrupalorgsandboxjustuno2061201git

----
Top Shelf Modules - Crafted, Curated, Contributed.

Hi,
In "justuno_page_build()" you should add to the comments "implements hook_page_build"

In "function justuno_menu()" you should comment "implements hook_menu()" instead of "Function justuno_menu()."

I think is not necessary include_once dirname(__FILE__) . '/JustunoAccess.inc'; becouse the class is autoloaded when you add "files[] = JustunoAccess.inc" in .info file.

In "function justuno_settings()" I think you are declaring but never using variables $result['key'] and $result['edit']

Probably there is a good reason but a I am not able to understand why are you creating a link in this way:

$form['step2']['content']['link'] = array(
    '#markup' => '<input type="button" class="form-submit" onClick="location.href=\'' . $link . '\';" value="Justuno dashboard" />',
  );

instead of with l() function?

Probably It would be useful to add a validate function to the mail field.

Regards.

Manual review:

• In .install file line 4: The comment after @file should describe the overall purpose of the file, not a specific hook implementation. Example form file.install: "Install, update and uninstall functions for File module."
• In .install file line 8: The comment before hook_requirements should say "Implements hook_requirements()."
• In .module file line 34: The function docblock should be more descriptive than just stating "Function foo_bar().". Describe what the function is for.
• In .module file line 95: The 'class' element has to be an array, see https://api.drupal.org/api/drupal/includes%21common.inc/function/l/7 and especially this comment https://api.drupal.org/comment/2608#comment-2608
• In .module file line 130: Typo in word, should be "retrieve".
• In .module file line 138-140: There should be a better solution for this. Please see https://api.drupal.org/api/drupal/includes!path.inc/function/path_is_adm... or https://api.drupal.org/api/drupal/includes!bootstrap.inc/function/arg/7 for more.
• You are setting a bunch or variables using variable_set(). Make sure you remove them properly using variable_del() in hook_uninstall().

Project page

Please take a moment to make your project page follow tips for a great project page. It's mostly buzzwords right now, can you describe what the module actually does?

• features_uninstall() should be renamed justuno_uninstall()

Otherwise this would be RTBC from me.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Sorry, I don't see a link on the project page?

Thanks for those updates.

----
Top Shelf Modules - Crafted, Curated, Contributed.

It's been a month without any problems reported, so I'm promoting this myself as per https://drupal.org/node/1125818.

Thanks for your contribution, Justuno!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.