Remove unused local variables from the Views UI module

"warning: 1 line adds whitespace errors."

Please delete unneeded spaces from a string 124.

Yeah this makes more sense.

Hmmm.... does it?

  /**
   * A helper method which creates a random view.
   */
  public function randomView(array $view = array()) {
    // Create a new view in the UI.
    $default = array();
    $default['label'] = $this->randomName(16);
    $default['id'] = strtolower($this->randomName(16));
    $default['description'] = $this->randomName(16);
    $default['page[create]'] = TRUE;
    $default['page[path]'] = $default['id'];

    $view += $default;

    $this->drupalPostForm('admin/structure/views/add', $view, t('Save and edit'));

    return $default;
  }

The drupalPostForm() here means that we should be on the view edit page. Doing $this->drupalGet($path_prefix); means that we need to make yet another request via the simpletest browser. I'd like to see this patch remove the unnecessary $this->drupalGet($path_prefix); from the other tests.

applied without any issues

Back to alexpott for review.

Please confirm that all other unused local variables are also removed from the Views UI module. Thanks!

Looks fine to me!

Cool, thanks. One thing...

+++ b/core/modules/views_ui/lib/Drupal/views_ui/Tests/DisplayTest.php
@@ -197,9 +194,7 @@ public function testCloneDisplay() {
   public function testDisableDisplay() {
     $view = $this->randomView();
-    $path_prefix = 'admin/structure/views/view/' . $view['id'] .'/edit';
 
-    $this->drupalGet($path_prefix);
     $this->assertFalse($this->xpath('//div[contains(@class, :class)]', array(':class' => 'views-display-disabled')), 'Make sure the disabled display css class does not appear after initial adding of a view.');
 

While this passes, it's only coincidentally so. The assertFalse() down below is making sure that the disabled class it not appearing, which of course it's not, because $this->xpath() is most likely being passed into it a blank string since we haven't actually retrieved an HTML page for it to check. :)

So I think those two need to be removed, but the rest looks fine.

@stevepurkiss what she means is please delete the two lines ( prefixed with '-' )
and the patch is good to go...

- $path_prefix = 'admin/structure/views/view/' . $view['id'] .'/edit';
- $this->drupalGet($path_prefix);

I hope this helps, I assume that you want to do this .. if not, I will lurk on this issue, and sort it out in about a week.

PS the patch still applies

Taking a crack at it..

ACK! thx

Hi, I was just told to look at this issue in core mentoring hours on #drupal IRC.

Patch attached.

Looks good to me! RTBC!

28: core-remove-unused-variable-2061397-28.patch queued for re-testing.

back to RTBC

All right, let's get this one in.

Committed and pushed to 8.x. Thanks!