Part of #2047951: [META] Remove calls to deprecated global $user and $GLOBALS['user']

CommentFileSizeAuthor
#15 overlay-remove-global-user-from-overlay-module-2061967-15.patch1.05 KBm1r1k
#14 drupal8.overlay-module.2061967-14.patch1.05 KBsergeypavlenko
#3 2061967-2.patch1.08 KBMaxis
#1 2061967-1.patch1.08 KBMaxis
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Maxis’s picture

Maxis CreditAttribution: Maxis commented
FileSize
2061967-1.patch1.08 KB
Spleshka’s picture

Spleshka
he/him
Primary language English
Location UAE
CreditAttribution: Spleshka commented
Status: Active » Reviewed & tested by the community

I see to reasons why we can't make it RTBC. Thanks!

Maxis’s picture

Maxis CreditAttribution: Maxis commented
Status: Reviewed & tested by the community » Needs review
FileSize
2061967-2.patch1.08 KB
Spleshka’s picture

Spleshka
he/him
Primary language English
Location UAE
CreditAttribution: Spleshka commented

Any difference between patches?

Maxis’s picture

Maxis CreditAttribution: Maxis commented

no differenece, but i forgot set status to needs review in my first comment..

Maxis’s picture

Maxis CreditAttribution: Maxis commented

Will bot put himself patch on the test?

Spleshka’s picture

Spleshka
he/him
Primary language English
Location UAE
CreditAttribution: Spleshka commented

Yep, he already did it. Just wait for the results. But patch seems to be obvious.

Maxis’s picture

Maxis CreditAttribution: Maxis commented

thanks$)

Maxis’s picture

Maxis CreditAttribution: Maxis commented

i did simple test, it returned 34 passes, 0 fails, 0 exceptions, and 9 debug messages

Spleshka’s picture

Spleshka
he/him
Primary language English
Location UAE
CreditAttribution: Spleshka commented

Wait for the test results. Patch won't get commited until it pass a test bot.

Status: Needs review » Needs work
Issue tags: -CodeSprintCIS

The last submitted patch, 2061967-2.patch, failed testing.

Spleshka’s picture

Spleshka
he/him
Primary language English
Location UAE
CreditAttribution: Spleshka commented
Status: Needs work » Needs review

#3: 2061967-2.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +CodeSprintCIS

The last submitted patch, 2061967-2.patch, failed testing.

sergeypavlenko’s picture

sergeypavlenko CreditAttribution: sergeypavlenko commented
Status: Needs work » Needs review
FileSize
drupal8.overlay-module.2061967-14.patch1.05 KB

Issue #2062151: Create a current user service to ensure that current account is always available Fix.

m1r1k’s picture

m1r1k CreditAttribution: m1r1k commented
FileSize
overlay-remove-global-user-from-overlay-module-2061967-15.patch1.05 KB

Rerolling after #2053489: Standardize on \Drupal throughout core

Status: Needs review » Needs work
Issue tags: -CodeSprintCIS

The last submitted patch, overlay-remove-global-user-from-overlay-module-2061967-15.patch, failed testing.

m1r1k’s picture

m1r1k CreditAttribution: m1r1k commented
Status: Needs work » Needs review
Issue tags: +CodeSprintCIS

#15: overlay-remove-global-user-from-overlay-module-2061967-15.patch queued for re-testing.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Assigned: Maxis » Unassigned
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Looks like #16 still applies, passes tests and does what the summary is requesting.

Thank you @m1r1kand, @sergeypavlenko, and @Maxis

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.