[D7] FlexSlider Field Collection

Hi,

Manual review :

• Maybe you should add ctools in the dependencies of the .info file since you are using ctools_include on line 99 flexslider_field_collection.module
• The variable $bundle might have not been define on line 189 flexslider_field_collection.module, you should add a !empty($bundle) in your condition

=)

You need to set the status to "needs review" if you want to get a review, see http://drupal.org/node/532400

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxgenjohnson2063343git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

• Link to git repository are not valid
• In REQUIREMENTS are no dependencies to modules ctools

• Master Branch

  It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

• Comments to fucntion _flexslider_field_collection_get_fields() is not corect

Project page

Please take a moment to make your project page follow tips for a great project page.

Otherwise this looks ready to go. There's a bunch of flexslider modules out now, can you mention some of the differences on your project page and fill it out in general?

----
Top Shelf Modules - Crafted, Curated, Contributed.

Looks nice, thanks!

----
Top Shelf Modules - Crafted, Curated, Contributed.

Adding link to CTools requirement and correcting link to git repository.

manual review:

1. flexslider_field_collection_field_formatter_settings_form(): no need to run $optionsets through check_plain() since #options in select form elements will be sanitized by the form API already, and double escaping is bad. Make sure to read https://drupal.org/node/28984 again.
2. _flexslider_field_collection_get_fields(): that switch() statement does not make sense, only one case?

But that are not blockers, so ...

Thanks for your contribution, genjohnson!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.