Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.| Comment | File | Size | Author |
|---|---|---|---|
| #5 | block-2065721-5.patch | 26.19 KB | tim.plunkett |
| #4 | block-2065721-3.patch | 26.05 KB | tim.plunkett |
| #4 | interdiff.txt | 5.83 KB | tim.plunkett |
| #1 | block-2065721-1.patch | 20.22 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettHere's a start
Comment #2
tim.plunkettComment #4
tim.plunkettDuh, I only did the ones that directly extended BlockBase, missed the sub-sub-classes.
Comment #5
tim.plunkettRerolled.
Comment #7
berdir#5: block-2065721-5.patch queued for re-testing.
Comment #8
benjy commentedOK I tested this, all works good.
I was a little confused at first where the module key had gone but I see it added in processDefinition(). Out of interest, are the array keys that are always available in $definition documented anyway?
Comment #9
tim.plunkettWell 'module' is a deprecated key anyway, we need to remove that in favor of 'provider', which is on every plugin ever and is never double documented in an annotation.
Comment #10
alexpottCommitted 0489b63 and pushed to 8.x. Thanks!
Need to update https://drupal.org/node/1880620
Comment #11
longwaveUpdated the change notice: https://drupal.org/node/1880620/revisions/view/2679430/2816749
Comment #12
berdirLooks ok to me.