Follow-up from #1966246: [meta] Introduce specific annotations for each plugin type.

CommentFileSizeAuthor
#5 block-2065721-5.patch26.19 KBtim.plunkett
#4 block-2065721-3.patch26.05 KBtim.plunkett
#4 interdiff.txt5.83 KBtim.plunkett
#1 block-2065721-1.patch20.22 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new block-2065721-1.patch20.22 KB

Here's a start

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, block-2065721-1.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt5.83 KB
new block-2065721-3.patch26.05 KB

Duh, I only did the ones that directly extended BlockBase, missed the sub-sub-classes.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new block-2065721-5.patch26.19 KB

Rerolled.

Status: Needs review » Needs work
Issue tags: -DX (Developer Experience), -Plugin system, -Annotation

The last submitted patch, block-2065721-5.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
Issue tags: +DX (Developer Experience), +Plugin system, +Annotation

#5: block-2065721-5.patch queued for re-testing.

benjy’s picture

benjy commented
Status: Needs review » Reviewed & tested by the community

OK I tested this, all works good.

I was a little confused at first where the module key had gone but I see it added in processDefinition(). Out of interest, are the array keys that are always available in $definition documented anyway?

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

Well 'module' is a deprecated key anyway, we need to remove that in favor of 'provider', which is on every plugin ever and is never double documented in an annotation.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: Add a dedicated @Block plugin annotation » Change notice: Add a dedicated @Block plugin annotation
Priority: Normal » Critical
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Committed 0489b63 and pushed to 8.x. Thanks!

Need to update https://drupal.org/node/1880620

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

Updated the change notice: https://drupal.org/node/1880620/revisions/view/2679430/2816749

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: Change notice: Add a dedicated @Block plugin annotation » Add a dedicated @Block plugin annotation
Priority: Critical » Normal
Status: Needs review » Fixed
Issue tags: -Needs change record

Looks ok to me.

Automatically closed -- issue fixed for 2 weeks with no activity.