this module implements the flattrthis widget as a block that lets you enter the flattr username, category and tags in its configuration form and outputs the flattrthis link with the count. Its built in the spirit of modules like facebook_boxes and doesnt attempt to do anything fancy.

Justification:

  • the flattr module is a flexible solution if you want multiple flattr buttons on your site but in the d7 version is not designed with a global block see the relevant issue https://drupal.org/node/1991016
  • no other module i found includes the flattr button with count.

Link to sandbox: Flattr block

I feel confident to maintain this and i will try to create a [D8] version of this module.

Comments

valic’s picture

valic
Primary language Croatian
Location Osijek
commented
Status: Active » Needs work

Hi,

PAReview automated test have found some issues (Coding standards and git / version related problems)

http://pareview.sh/pareview/httpgitdrupalorgsandboxdiscipolo1991012git

It's good always to check with PAReview online or local for errors

discipolo’s picture

discipolo commented
Status: Needs work » Needs review

due to https://drupal.org/node/2066525 i cannot remove the master branch currently. the other issues should be taken care of

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Assigned: Unassigned » klausi

I'll look at this now in the Project applications sprint

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Assigned: klausi » Unassigned
Status: Needs review » Needs work

manual review:

  1. Project page could use some tuning, especially the differences to the existing flattr module.
  2. flattrblock.css is missing?
  3. dependency to block module is missing?
  4. flattrblock_content(): I think that should be a theme function, so that themes can override it.
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

tips for a great project page: https://drupal.org/node/997024

discipolo’s picture

discipolo commented
Status: Needs work » Needs review

issues raised in #4 should be fixed, in commit af60fe31dfd68e1c2e041487a25474f1fe7594bd
I embelished the project page some more. i will fix the default branch as soon as it becomes possible.

i probably should initialise the variables in flattrblock_theme with a NULL value, will remedy that Momentarily.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Reviewed & tested by the community

manual review:

  1. "'#markup' => theme_flattrblock_link($which_block),": do not hard-code your theme function, use theme('flattrblock_link', ...) instead.
  2. theme_flattrblock_link(): a theme function has only one parameter, which is $variables, right?
  3. theme_flattrblock_link(): doc block is wrong, see https://drupal.org/node/1354#themeable
  4. theme_flattrblock_link(): you should not load stuff from the database with variable_get() in a theme function, that should be passed in in the variables array.

But otherwise looks RTBC to me.

discipolo’s picture

discipolo commented

i adressed the issues raised in #7. one thing i havent yet managed so far is implement a render array as outlined in the first two paragraphs https://api.drupal.org/api/drupal/includes!theme.inc/function/theme/7

i added a todo section to the readme, fixed the default git branch and will add a link to the readme to the project page anything else i can do?

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)
Possible Duplication
It seems that Flattr provides very similar functionality. Could you provide a patch to that module that implements a global flattr block instead of this new module? It would be nice to keep all the Flattr api code together. You can still receive Git Vetted Status for this application, I'm just recommending against promoting this to a full project.

We prefer collaboration over competition, therefore we want to prevent having duplicating modules on drupal.org. If the differences between these modules are not too fundamental for patching the existing one, we would love to see you joining forces and concentrate all power on enhancing one module. (If the existing module is abandoned, please think about taking it over).

If that fails for whatever reason please get back to us and set this back to "needs review".

Minor points:

  • In hook_uninstall(), variable_del('base_url'); is wrong. $base_url is a Drupal global, just let it be :)
  • In theme_flattrblock_link() why do you have $attributes['lang'] = array('de' => 'de_DE'); ?

----
Top Shelf Modules - Crafted, Curated, Contributed.

discipolo’s picture

discipolo commented
Status: Postponed (maintainer needs more info) » Needs review

https://drupal.org/node/1991016#comment-7397454
please have a look at the flattr maintainers feedback about implementing a block. i offered to make turn this into a patch but created this sandbox http://drupal.org/sandbox/discipolo/1999150 instead which is meant to be implemented as a flattr component.

as i wrote in my project application a simple flattr block is not available in flattr D7 by design which is why i am applying for a full project.

i will fix the uninstall issue momentarily.
theme flattrblock links contrains the language attribute for generating the link the way flattr expects it, i might have to add the language handling to my todolist if there is something i forgot to add @see http://developers.flattr.net/button/

PA robot’s picture

PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Needs review » Fixed

Sorry, I didn't see that the module maintainer already rejected your request. I think he's wrong, but that shouldn't hold up this application. Since it was previously RTBC by klausi...

Thanks for your contribution, discipolo!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as we

----
Top Shelf Modules - Crafted, Curated, Contributed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.