Updated: Comment #6

Problem/Motivation

The search module's block is missing from place blocks because the category key matches that of the filter input field.

block ui page screenshot

Proposed resolution

Move the Place blocks header and filter input outside of the "list" element container.
Write test to make sure search appears in admin UI (or some other test).

Remaining tasks

None

User interface changes

Markup for the place block right sidebar changes.

API changes

None

None

Original report by geerlingguy

(Text of the original report, for legacy issues whose initial post was not the issue summary. Use rarely.)

It looks like the conversion of the Search module's blocks (as part of #1535868: Convert all blocks into plugins) may have made search.module's blocks to not work correctly anymore. I'm getting the following error when I try installing the standard profile:

The plugin (search_form_block) did not specify an instance class.

Also, none of the search blocks appear on the Blocks UI page.

CommentFileSizeAuthor
#11 Screen Shot 2013-08-17 at 5.03.08 PM.png491.84 KBkerasai
#10 drupal8.block-module.2067881-10.patch2.21 KBZenDoodles
#10 interdiff.txt661 bytesZenDoodles
#7 drupal8.block-module.2067881-7.patch2.22 KBZenDoodles
#4 drupal8.block-module.2067881-4-tests.patch840 bytesZenDoodles
#1 search-form-working.png40.99 KBmradcliffe
#1 block-ui-page.png121.21 KBmradcliffe

Comments

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Issue tags: +Needs steps to reproduce
StatusFileSize
new block-ui-page.png121.21 KB
new search-form-working.png40.99 KB

I installed 8.x from HEAD this morning as well, and search form was enabled.

I did not see Search in the Admin UI page for adding a new search block, but I did see search form in added, and it was working correctly.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Title: The plugin (search_form_block) did not specify an instance class on standard install profile installation » Search is missing from block admin UI after installation
Issue tags: +Needs issue summary update

Re-named issue.

geerlingguy’s picture

geerlingguy commented

(To clarify): The original bug report (with the error about not specifying an instance class) was a result of the patch I'm working on in #1356276: Allow profiles to define a base/parent profile; the actual bug being reported is the Search module's blocks not showing anywhere in the Configure Blocks admin/ui. The issue summary needs to be updated to reflect this.

ZenDoodles’s picture

ZenDoodles commented
Issue tags: -Needs steps to reproduce
StatusFileSize
new drupal8.block-module.2067881-4-tests.patch840 bytes

Steps to reproduce

1. Install Drupal 8.
2. Navigate to admin/structure/block
3. Note the lack of a Search form block in the "Place block" list on the right.
No search block image.

Failing test patch attached.

ZenDoodles’s picture

ZenDoodles commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, drupal8.block-module.2067881-4-tests.patch, failed testing.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Issue summary: View changes

Updated issue summary

ZenDoodles’s picture

ZenDoodles commented
Issue tags: +MWDS2013
StatusFileSize
new drupal8.block-module.2067881-7.patch2.22 KB
ZenDoodles’s picture

ZenDoodles commented
Status: Needs work » Needs review
mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented 
@@ -312,6 +310,10 @@ public function buildForm(array $form, array &$form_state) {
       ),
     );
 
+    $form['right']['list']['#type'] = 'container';
+    $form['right']['list']['#attributes']['class'][] = 'entity-meta';
+
+
     // Sort the plugins first by category, then by label.
     $plugins = $this->blockManager->getDefinitions();

There is an extra line break.

ZenDoodles’s picture

ZenDoodles commented
StatusFileSize
new interdiff.txt661 bytes
new drupal8.block-module.2067881-10.patch2.21 KB
kerasai’s picture

kerasai commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2013-08-17 at 5.03.08 PM.png491.84 KB

Screen Shot 2013-08-17 at 5.03.08 PM.png

  • Patch applied cleanly.
  • Search block now available for addition in the place blocks screen.
  • Filter action successful.
kerasai’s picture

kerasai commented
Issue summary: View changes

Updated issue summary.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Issue tags: -Needs issue summary update

Remove tag.

ZenDoodles’s picture

ZenDoodles commented

Please also @mradcliffe for commit credit.

Thanks!

geerlingguy’s picture

geerlingguy commented

Another RTBC vote here; after patch, I can place the search form. Sadly, this still doesn't fix #1356276: Allow profiles to define a base/parent profile (I didn't think it would, but there's always hope!).

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

I can confirm that the test fails without the changes to core/modules/block/lib/Drupal/block/BlockListController.php

Committed 3c2bee1 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Update issue summary.

winternett’s picture

winternett commented

I don't see the block options (on the right side of my block admin page) at all... I'm very confused as to how to get nodes to show as blocks in d8 so that I can assign them to regions in D8...?

I'm using drupal 8.1.2

The nodeblocks module isn't yet ported to D8, I used it in D7 regularly for this purpose.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented

@winternett, thanks for searching before creating a support request or new forum topic. This bug report was from about 3 years ago fixing an issue with the block admin interface. The interface has changed significantly since that period of time (click on the Place Block link to add a block that has already been defined). You may want to look at using views.

winternett’s picture

winternett commented

Thanks @mradcliffe I did create a view that outputs my blocks thus far, but I though it would be bad practice to create several individual views for blocks on a homepage to display rather than having simple individual node-based blocks that I could assign to my custom regions using context? Maybe I need to wait for a port of the nodeblock module...