Convert taxonomy term SQL queries to the Entity Query API

First stab, I can't get tests to run locally on my windows box without timing out.

Also a lot of the queries against taxonomy_term_data are not efqable so this patch also extends interfaces. Also doesn't touch anything in views yet.

#3: remove-taxonomy-data-query.patch queued for re-testing.

1. +++ b/core/modules/taxonomy/lib/Drupal/taxonomy/TermStorageControllerInterface.php
   @@ -31,4 +31,58 @@ public function deleteTermHierarchy($tids);
   +   * @param Integer $tid
   +   *   Term id to retrieve parents for.
   ...
   +   * @param Integer $tid
   +   *   Term id to retrieve parents for.
   

   *int

2. +++ b/core/modules/taxonomy/lib/Drupal/taxonomy/TermStorageControllerInterface.php
   @@ -31,4 +31,58 @@ public function deleteTermHierarchy($tids);
   +   * @param Integer $vid
   +   *   An optional vocabulary ID to restrict the child search.
   ...
   +   * @param Integer $vid
   +   *   Vocabulary ID to retrieve terms for.
   ...
   +   * @param Integer $vid
   +   *   Vocabulary ID to retrieve terms for.
   ...
   +   * @param Integer $vid
   +   *   Vocabulary ID to retrieve terms for.
   

   $vid is a string.

3. +++ b/core/modules/taxonomy/taxonomy.module
   @@ -522,14 +522,7 @@ function taxonomy_term_load_parents($tid) {
   +    $tids = \Drupal::entityManager()->getStorageController('taxonomy_term')->loadParents($tid);
   ...
    
   
   @@ -577,17 +570,7 @@ function taxonomy_term_load_children($tid, $vid = NULL) {
   +    $tids = \Drupal::entityManager()->getStorageController('taxonomy_term')->loadChildren($tid);
   
   @@ -628,16 +611,7 @@ function taxonomy_get_tree($vid, $parent = 0, $max_depth = NULL, $load_entities
   +    $result = \Drupal::entityManager()->getStorageController('taxonomy_term')->loadTree($vid);
   
   +++ b/core/modules/taxonomy/taxonomy.tokens.inc
   @@ -167,21 +167,15 @@ function taxonomy_tokens($type, $tokens, array $data = array(), array $options =
   +          $replacements[$original] = \Drupal::entityManager()->getStorageController('taxonomy_term')->nodeCount($vocabulary->id());
   

   Can we wrap these?

1 & 2 yes I'll do point 3 to be honest is more readable as is in my opinion.

Works for me.

Ok docs fixed.

Looks good to me, only found some tiny nitpicks with namespace ordering (my favourite pet peeve :), and capitalization of the word "ID" in the documentation. AFAIAC this is RTBC.

Looks good to me.

#10: 2068337-10-taxonomy-entiry_query_api.patch queued for re-testing.

Committed/pushed to 8.x, thanks!