[D7] Search API Fivestar

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Demoshane,

Add [D7] in issue title ( [D7] Search API Fivestar ).

Hello Demoshane.

I've added a couple of quick notes before trying your module out and giving further feedback.

Here are the few notes:

1. Your readme file is blank. Do you want to add more info to it? Perhaps at least what's on your project description page.

2. You mention on the project page that the Solr won't index the five star ratings correctly. Can you describe that further? For example, saying what it does now and what it actually should do and how your module fixes this.

3. Minor note: You have a variable name "avarage" in search_api_fivestar.module on line 52. Perhaps this is on purpose?

4. I'm curious about the performance of the calculations in: search_api_fivestar_current_user_rating_getter_callback and search_api_fivestar_avarage_user_rating_getter_callback. Are they not called that often? Is there any need for caching?

More to come. Hope this helps.

Please change status only after applying described changes.
Also, please consider this https://drupal.org/node/539608 page. Your application cannot be accepted till you fixed mentioned problems.

This is an excellent module that I'd like to see moved to a live project page. I will be assisting with documentation for the initial project page release (provided module creator supports this, which we've discussed over email).

This will include augmenting the existing "Readme" file that accompanies the module.

Your project page says "Atleast", and "Avarage" is misspelled in some variable and function names, it should be "average".

Could this module live as part of the fivestar or searchapi modules? Would users expect this to be the default behavior without having to include a contrib module?

----
Top Shelf Modules - Crafted, Curated, Contributed.

i don't understand why it would be included with five star or searchapi - both of those modules already have "extras" modules surrounding them, as do countless others on drupal.

in the case of fivestar, it would seem to make some sense but would then place an additional support burden on the fivestar maintainer who is already inundated with requests for support or features on the already popular module. in that scenario, feature requests or support requests would get lost in the noise.

i think of this more like a 'views hacks' external - because while views handles (for example) "tables," why shouldn't it also just own "flipped tables"? similar for five star...

btw, how is search api currently calculating five star ratings? when i view the 'add fields' option within the index and search api settings, i DO see already the ability to add in my field name that represents the voting/fivestar - but i'm unclear about what it is gathering from the field.

in basic terms, when you say "won't index correctly" i'm just trying to understand what it is that searchapi does with fivestar "out of the box"

do you mean that it can not expose, for example, a 'facet' that will allow for sorting by fivestar ranking in any way?

yup, just realized that when i tried to use it in the index and expose as a facet with search api...in fact, even after reindexing the block will not show up (likely because it is generating zero results across the board with a slew of zeros!)

i know, it's maddening - it appropriately picks up the named field that uses fivestar and then basically does nothing with it!

bump: what will it take at this point - October 2nd 2013- to move this to a project page with a dev and a beta release?

note: should this be merged with Apache Solr Voting API? and then this would extend to search api?
https://drupal.org/project/apachesolr_votingapi

No further action is required, but the best thing you can do is get a Review Bonus by reviewing other applications. That will get you to the top of the list of projects to get reviewed (and hopefully approved). Only manual reviews count, just using http://pareview.sh is not enough.

----
Top Shelf Modules - Crafted, Curated, Contributed.

It's been a month without any problems reported, so I'm promoting this myself as per https://drupal.org/node/1125818.

Thanks for your contribution, Demoshane!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.

congratulations demoshane! now we get to hammer your issue queue with requests ;)