This patch is intended to be part 1 of a 2 part solution for field collection support with UUID. This patch removes field collection support entirely from the uuid.core.inc file.

CommentFileSizeAuthor
#12 uuid-2074599-drop-contrib-12.patch5.35 KBskwashd
#4 uuid_remove_contrib_support-2074599-2.patch3.37 KBtimaholt
#3 uuid_remove_contrib_support-2074599.patch2.99 KBtimaholt
uuid_remove_field_collection.patch1.24 KBtimaholt

Comments

timaholt’s picture

timaholt commented
Title: Remove Field Collection functions from the UUID module » Remove all Contrib module functions from uuid.core.inc
Status: Needs review » Needs work

I'm changing this to actually remove all the contrib module functions from uuid.core.inc. Then will include links to patches for the individual modules that add this support back in.

skwashd’s picture

skwashd commented

I support dropping support for all contrib modules from uuid core. Support should be included in the contrib modules. In many cases uuid can just become a soft dependency for the module. Where the module exposes an entity the maintainer can ship a [module_name]_uuid sub module to add UUID support if they don't want to add a dependency.

Given entity reference is going into D8 core, I am happy for it to remain in uuid.core.inc with a short comment explaining why it has been retained.

timaholt’s picture

timaholt commented
StatusFileSize
new uuid_remove_contrib_support-2074599.patch2.99 KB

Here is the full patch to remove contrib support.

timaholt’s picture

timaholt commented
StatusFileSize
new uuid_remove_contrib_support-2074599-2.patch3.37 KB

Forgot the comment about keeping entity_reference included.

timaholt’s picture

timaholt commented

First of many updates for contrib modules patches.

Field Collection UUID support: https://drupal.org/node/2075325 (this contains a patch for field_collection to add a field_collection_uuid submodule)

timaholt’s picture

timaholt commented

References support: https://drupal.org/node/2075409 (this contains a patch for references to add a references_uuid submodule)

timaholt’s picture

timaholt commented
Title: Remove all Contrib module functions from uuid.core.inc » Remove all Contrib module functions from uuid.core.inc, plus reference where UUID support is for contrib modules

Webform support: https://drupal.org/node/837594#comment-7799535

timaholt’s picture

timaholt commented

Node Hierarchy support: https://drupal.org/node/2075467

indytechcook’s picture

indytechcook commented

Webform support moved to #2076483: Support UUIDs for Feature Exporting

sylus’s picture

sylus commented

Workbench support: #2140107: Support for UUID/Deploy

skwashd’s picture

skwashd commented
Issue summary: View changes

Redirect support #1517348: Add support for UUID/Deploy module.

skwashd’s picture

skwashd commented
Status: Needs work » Needs review
StatusFileSize
new uuid-2074599-drop-contrib-12.patch5.35 KB

We need some additional changes in uuid_services. The attached patch includes those changes.

skwashd’s picture

skwashd commented
Status: Needs review » Fixed

The bot was happy, so am I - committing this.

  • skwashd committed 2d54efc on 7.x-1.x authored by timaholt 
    Issue #2074599 by timaholt, skwashd: Remove all contrib module suppport
dixon_’s picture

dixon_
he/him
Primary language English
Location France
commented

@skwashd I don't think we have tests for any of those changes. But it should be fine.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

skwashd’s picture

skwashd commented
skwashd’s picture

skwashd commented
Related issues: +#2140107: Support for UUID/Deploy, +#2075409: Add UUID/Deploy support locally in the References project, +#2075325: Provide a Field Collection UUID module to support UUID/Deploy, +#1517348: Add support for UUID/Deploy module