When an entity is in-place edited (i.e. saved), other instances of that entity on the same page are not updated (no propagation)

5: edit_change_propagation-2075185-5.patch queued for re-testing.

I'm getting an error when editing the body of an article node on the full view, with the imported views in the sidebar.

Uncaught AjaxError: 
An AJAX HTTP error occurred.
HTTP Result Code: 200
Debugging information follows.
Path: /edit/form/node/1/body/en/full
StatusText: OK
ResponseText:  

The AJAX return object status is 'parsererror'.

PHP stack trace:

[11-Dec-2013 18:44:36 UTC] PHP Fatal error:  Using $this when not in object context in /Users/jbeach/code/drupal/core/d8/core/modules/edit/lib/Drupal/edit/EditController.php on line 239
[11-Dec-2013 18:44:36 UTC] PHP Stack trace:
[11-Dec-2013 18:44:36 UTC] PHP   1. {main}() /Users/jbeach/code/drupal/core/d8/index.php:0
[11-Dec-2013 18:44:36 UTC] PHP   2. drupal_handle_request($test_only = *uninitialized*) /Users/jbeach/code/drupal/core/d8/index.php:15
[11-Dec-2013 18:44:36 UTC] PHP   3. Drupal\Core\DrupalKernel->handle($request = *uninitialized*, $type = *uninitialized*, $catch = *uninitialized*) /Users/jbeach/code/drupal/core/d8/core/includes/bootstrap.inc:1886
[11-Dec-2013 18:44:36 UTC] PHP   4. Drupal\Core\HttpKernel->handle($request = *uninitialized*, $type = *uninitialized*, $catch = *uninitialized*) /Users/jbeach/code/drupal/core/d8/core/lib/Drupal/Core/DrupalKernel.php:282
[11-Dec-2013 18:44:36 UTC] PHP   5. Symfony\Component\HttpKernel\HttpKernel->handle($request = *uninitialized*, $type = *uninitialized*, $catch = *uninitialized*) /Users/jbeach/code/drupal/core/d8/core/lib/Drupal/Core/HttpKernel.php:52
[11-Dec-2013 18:44:36 UTC] PHP   6. Symfony\Component\HttpKernel\HttpKernel->handleRaw($request = *uninitialized*, $type = *uninitialized*) /Users/jbeach/code/drupal/core/d8/core/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/HttpKernel.php:61
[11-Dec-2013 18:44:36 UTC] PHP   7. call_user_func_array(*uninitialized*, *uninitialized*) /Users/jbeach/code/drupal/core/d8/core/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/HttpKernel.php:117
[11-Dec-2013 18:44:36 UTC] PHP   8. Drupal\Core\Controller\AjaxController->content($request = *uninitialized*, $_content = *uninitialized*) /Users/jbeach/code/drupal/core/d8/core/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/HttpKernel.php:117
[11-Dec-2013 18:44:36 UTC] PHP   9. Drupal\Core\HttpKernel->forward($controller = *uninitialized*, $attributes = *uninitialized*, $query = *uninitialized*) /Users/jbeach/code/drupal/core/d8/core/lib/Drupal/Core/Controller/AjaxController.php:55
[11-Dec-2013 18:44:36 UTC] PHP  10. Drupal\Core\HttpKernel->handle($request = *uninitialized*, $type = *uninitialized*, $catch = *uninitialized*) /Users/jbeach/code/drupal/core/d8/core/lib/Drupal/Core/HttpKernel.php:81
[11-Dec-2013 18:44:36 UTC] PHP  11. Symfony\Component\HttpKernel\HttpKernel->handle($request = *uninitialized*, $type = *uninitialized*, $catch = *uninitialized*) /Users/jbeach/code/drupal/core/d8/core/lib/Drupal/Core/HttpKernel.php:52
[11-Dec-2013 18:44:36 UTC] PHP  12. Symfony\Component\HttpKernel\HttpKernel->handleRaw($request = *uninitialized*, $type = *uninitialized*) /Users/jbeach/code/drupal/core/d8/core/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/HttpKernel.php:61
[11-Dec-2013 18:44:36 UTC] PHP  13. call_user_func_array(*uninitialized*, *uninitialized*) /Users/jbeach/code/drupal/core/d8/core/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/HttpKernel.php:117
[11-Dec-2013 18:44:36 UTC] PHP  14. Drupal\edit\EditController->fieldForm($entity = *uninitialized*, $field_name = *uninitialized*, $langcode = *uninitialized*, $view_mode_id = *uninitialized*, $request = *uninitialized*) /Users/jbeach/code/drupal/core/d8/core/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/HttpKernel.php:117
[11-Dec-2013 18:44:36 UTC] PHP  15. Drupal\edit\{closure}($view_mode_id = *uninitialized*) /Users/jbeach/code/drupal/core/d8/core/modules/edit/lib/Drupal/edit/EditController.php:243

So it appears that for some Views output, the content will not update, because the necessary markup is not present, specifically the data-edit-field-id attribute. So, in the case that this attribute exists on the field, the content updates on save, as show in this image:

To address the code unraveling, I opened the following issue and linked it to #2152073 (Bump Drupal core's PHP requirement to 5.4.2).

#2156793: Unravel a PHP 5.4 workaround for Edit module once Drupal requires PHP 5.4

So, this issue resolves the multiple node instance update problem without regressions.

I posted the hack unraveling patch here: #2156793-1: Unravel a PHP 5.4 workaround for Edit module once Drupal requires PHP 5.4

1. +++ b/core/modules/edit/js/models/FieldModel.js
   @@ -61,6 +70,9 @@ Drupal.edit.FieldModel = Backbone.Model.extend({
   +
   +    //
   +    this.set('logicalFieldID', this.get('fieldID').split('/').slice(0, 4).join('/'))
      },
   

   Unfinished thought? :)

2. +++ b/core/modules/edit/js/models/FieldModel.js
   @@ -112,6 +124,49 @@ Drupal.edit.FieldModel = Backbone.Model.extend({
   +    // Second, figure out if there are .
   

   Another one? :)

Not moving down from RTBC but I don't have mental capacity to review this just yet so if it happens to get fixed in the next day or so then yay. :)

Looks good. Small but important clean-up. Committed to 8.x.