Automated project review for the 7.x-1.x branch reported several errors that we should be able to fix without too much trouble, since it's mostly coding standards errors (spaces missing, wrong indent, missing empty lines, Doc Comments blocks syntax, etc...).

In order to prepare for an upcoming stable release, let's try to bring back module's code in compliance with coding standards and fix all validation errors.

There shouldn't be any change of code, other than the ones recommended by the coding standards PAReview report.

Please let me know if you would have any questions, objections, comments, suggestions, recommendations or concerns on any aspects of this task, I would be glad to provide more information or explain in more details.

Any questions, feedback, testing, changes, recommendations would be highly appreciated.
Thanks to all in advance.

Comments

dydave’s picture

dydave commented
Status: Active » Fixed

Quick follow-up on this task:

PAReview is not prompting any errors anymore for the 7.x-1.x branch.
7.x-1.x PAReview report: no more coding standards errors after changes were committed at 52b6475 and e918dbd (really minor fix of the last coding standards issue reported by .

No complicated changes were made, just fixed errors as indicated by the reports: wrong spaces, break down too long inline comments, standardize Doc comments blocks, add full stops at end of lines of inline comments, etc....

I have tested a little bit and everything seems to work as expected, but I would greatly appreciate if you could let me know if anybody encounters any issue with the latest commits related with coding standards, I would surely try doing a quick fix as soon as possible.

I allowed myself to mark this issue as fixed for now, but feel free to re-open it, or create a new ticket, at any time if you have any further objections with this issue or any of the related commits (52b6475, e918dbd - we would surely be happy to hear your feedback).

Please let me know if you would have any further comments, feedback, questions, issues, objections, suggestions or concerns on the commits or this task in general, I would be glad to provide more information or explain in more details.

Thanks in advance to everyone for your testing, reviews, feedback and comments on this issue.
Cheers!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.