Bug with hidden display type when we've using field_create_instance in field_collection.module [#2077577]

I'm using the field_collection 7.x-1.0-beta5+1-dev (which is the current dev version) and I have a bug in field_collection.module line 1751 when I'm using field_create_instance if one of my display type is hidden. I think it's related to the test done juste before where we've testing only on the 'field_collection_fields' display type.

I attached quick patch to resolve this. Please apply before this patch http://www.drupal.org/files/field_collection-feeds-1063434-121.patch.

Comment	File	Size	Author
#7	field_collection-merge-multiple-patches-2077577-7.patch	103.52 KB	jdidelet
#7
#6	field_collection-merge-multiple-patches-2077577-6.patch	27.14 KB	jdidelet
#6
#5	field_collection-merge-multiple-patches-2077577-5.patch	28.77 KB	jdidelet
#5
#4	field_collection-mergin-patches-1344672-53_1063434-121_2077577-4.patch	27.05 KB	jdidelet
#4
#3	field_collection-mergin-patches-1344672-53_1063434-121_2077577-3.patch	27.05 KB	jdidelet
#3
#2	0003-Fixed-bug-check-if-we-don-t-have-hidden-or-field_col.patch	27.44 KB	jdidelet
#2
#1	0002-Fixed-bug-check-if-we-don-t-have-hidden-or-field_col.patch	1.01 KB	jdidelet
#1
	0001-Fixed-bug-check-if-we-don-t-have-hidden-or-field_col.patch	1.14 KB	jdidelet

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jdidelet CreditAttribution: jdidelet commented 2 September 2013 at 07:32

File	Size
0002-Fixed-bug-check-if-we-don-t-have-hidden-or-field_col.patch	1.01 KB

attached new version of the patch based on the 7.x-1.0-beta5

Comment #2

jdidelet CreditAttribution: jdidelet commented 2 September 2013 at 07:59

File	Size
0003-Fixed-bug-check-if-we-don-t-have-hidden-or-field_col.patch	27.44 KB

patch compatible after this patch https://drupal.org/node/1344672#comment-7784547 and https://drupal.org/node/1063434#comment-7792223 on the current dev version.

Comment #3

jdidelet CreditAttribution: jdidelet commented 2 September 2013 at 09:24

File	Size
field_collection-mergin-patches-1344672-53_1063434-121_2077577-3.patch	27.05 KB

for thos who might be interest, I merged multiple patch related to the feeds issue and and entity translation patch + this one (and properly generate and rename this one).