In #1497374: Switch from Field-based storage to Entity-based storage there are not yet explicit tests for a field with data shared between two different entity types. That's one of the trickier bits of the patch so we should really have explicit coverage. Given that patch is 580kb and blocks several others, and it's been manually tested for this case, I'm going to commit it without those tests, but adding them should block both release and a beta so we don't get nasty surprises later.

Files: 
CommentFileSizeAuthor
#7 field_upgrade_test-2078507-7.patch12.23 KByched
PASSED: [[SimpleTest]]: [MySQL] 58,865 pass(es).
[ View ]
#7 interdiff.txt1.83 KByched
#5 field_upgrade_test-2078507-5.patch12.31 KByched
FAILED: [[SimpleTest]]: [MySQL] 58,743 pass(es), 3 fail(s), and 0 exception(s).
[ View ]
#5 interdiff.txt2.12 KByched
#3 field_upgrade_test-2078507-3.patch11.06 KByched
FAILED: [[SimpleTest]]: [MySQL] 58,387 pass(es), 1 fail(s), and 1 exception(s).
[ View ]

Comments

Issue tags:+Field API, +Entity Field API

Tagging.

Title:Add explicit tests for fields shared between entitiesAdd explicit upgrade path tests for fields shared between entities

Status:Active» Needs review
StatusFileSize
new11.06 KB
FAILED: [[SimpleTest]]: [MySQL] 58,387 pass(es), 1 fail(s), and 1 exception(s).
[ View ]

Patch - didn't test locally, let's see if I got everything right.

Status:Needs review» Needs work

The last submitted patch, field_upgrade_test-2078507-3.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new2.12 KB
new12.31 KB
FAILED: [[SimpleTest]]: [MySQL] 58,743 pass(es), 3 fail(s), and 0 exception(s).
[ View ]

- Silly mistakes in the test d7 dump data (the shared field was marked 'deleted').
- There was indeed a problem with the upgrade path... A shared field got split in separate fields per entity types, but instances didn't point back to the correct field.

Status:Needs review» Needs work

The last submitted patch, field_upgrade_test-2078507-5.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new1.83 KB
new12.23 KB
PASSED: [[SimpleTest]]: [MySQL] 58,865 pass(es).
[ View ]

I changed the way we test field values, and it doesn't work (text values come up with the extra 'safe_*' property currently).
Reverted to the previous way.

Status:Needs review» Reviewed & tested by the community

Marvelous, RTBC when green.

Status:Reviewed & tested by the community» Fixed

Committed to 8.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.