Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
.
Comment | File | Size | Author |
---|---|---|---|
screenshot.png | 41.94 KB | shafiqissani |
.
Comment | File | Size | Author |
---|---|---|---|
screenshot.png | 41.94 KB | shafiqissani |
Comments
Comment #1
shafiqissani CreditAttribution: shafiqissani commentedComment #2
shafiqissani CreditAttribution: shafiqissani commentedComment #3
PA robot CreditAttribution: PA robot commentedLink to the project page and git clone command are missing in the issue summary, please add them.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #4
shafiqissani CreditAttribution: shafiqissani commentedComment #5
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxshafiqissani2078519git
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #6
shafiqissani CreditAttribution: shafiqissani commentedComment #7
artem_sylchukYou can find the results of the automated report at http://pareview.sh/pareview/httpgitdrupalorgsandboxshafiqissani2078519git.
Also
The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.
Also you probably will have problems with custom jquery included into your theme. Please consider this manual: https://drupal.org/node/1058168
Comment #8
shafiqissani CreditAttribution: shafiqissani commentedComment #9
shafiqissani CreditAttribution: shafiqissani commentedfixed
Comment #10
aramboyajyan CreditAttribution: aramboyajyan commentedOverview
It is not clear what issues does this theme solve/provide. Explain please how is it different that two other existing H5BP themes?
Code
template.php
use
href="<?php print path_to_theme() . base_path(); ?>/img/touch/[...]"
instead ofhref="img/touch[...]"
use
if ($tabs)
instead ofif ($tabs = render($tabs))
see core themes for guideline, e.g. Bartik
http://code.jquery.com/[...]
you should use//code.jquery.com/[...]
See pareview.sh results for more issues. Also before submitting your theme make sure that you check it with Coder module. Right not it returns 95 normal warnings.
Git
No track of the history. There are four commits in total, out of which 2 are "Initial commits".
I suggest re-creating the history and saving the progress step by step, as that will show others what your commit-style is and that you are familiar with using Git for regular tasks.
Bottom line
Unfortunately, too many technical mistakes. I believe it would be better to postpone the development of this theme.
Add more new features so it is different than two existing ones and improve the knowledge of Drupal coding.
This should be confirmed by other members. Changing status to "Needs work".
@shafiqissani let me know if you have any comments.
Comment #11
kscheirerdrupal_add_js('http://code.jquery.com/jquery-2.0.3.min.js', 'external');
, Drupal already comes with jQuery. Won't loading 2 versions of the same library cause problems?----
Top Shelf Modules - Crafted, Curated, Contributed.
Comment #11.0
kscheireradded link and drupal version.
Comment #12
shafiqissani CreditAttribution: shafiqissani commentedComment #12.0
shafiqissani CreditAttribution: shafiqissani commented.
Comment #13
PA robot CreditAttribution: PA robot commentedProject 1: https://www.drupal.org/node/2127077
Project 2: https://www.drupal.org/node/2078603
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #14
apaderno