[D7] GEDparse

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxComboPrime2078681git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

hi,

I had a quick review and below are my observations :

1) coder throws following warnings:
Line 103: Avoid backslash escaping in translatable strings when possible, use '' quotes instead [sniffer_semantics_functioncall_backslashdoublequote]
$access_message .= ' ' . t("Please contact @admin if you are a family member.",
Line 1131: Line exceeds 80 characters; contains 81 characters [sniffer_files_linelength_toolong]
// By default, preg_grep retains the input array's keys, so need to reset keys.
Line 1188: Expected 1 space after "?"; 0 found [sniffer_squiz_whitespace_operatorspacing_nospaceafter]
$output .= $name['full_name'] ?: 'Name unknown';
Line 1188: Expected 1 space before ":"; 0 found [sniffer_formatting_spacecolon_nospacebefore]
$output .= $name['full_name'] ?: 'Name unknown';
Line 1194: Expected 1 space after "?"; 0 found [sniffer_squiz_whitespace_operatorspacing_nospaceafter]
$output .= $name['#full_name'] ?: 'Name unknown';
Line 1194: Expected 1 space before ":"; 0 found [sniffer_formatting_spacecolon_nospacebefore]
$output .= $name['#full_name'] ?: 'Name unknown';
Line 1212: Files must end in a single new line character [sniffer_whitespace_fileend_fileend]

2) After simply going throw the code, I saw complexity of the functions is very high (lots of if and else).

Otherwise, this looks to very simple and clean module.

Thanks

changing status...

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.