[D7] PM User Image

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxjoshirohit1002079287git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Please fix below

1. Better to add a description in the menu that you have created.
2. Typo Image Weight should be image width in the settings form.

Hi Rohit,

Can you please try to include CSS file (pm_user_image.css) conditionally instead of adding it through hook_init. Now this CSS (pm_user_image.css) is included on each and every page across the application.

~Paritosh

Review of the 7.x-1.x branch

1. pm-user-image.inc (15) you mast use a t() function and use #prefix and #suffix in form.
2. pm-user-image.inc (45) you mast use in function t() - plasecholders.
3. pm-user-image.module (47) pm_user_image_autocomplete_change fucntion don't have comments to code (see module Privatemsg, file privatemsg.pages.inc, function privatemsg_autocomplete).
4. pm-user-image.module function theme may transfer html structure to tpl.php file from theme.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Hey Joshi,

Your file pm-user-image.inc should most likely be pm_user_image.inc, also consider an easier file definition name like pm_user_image.admin.inc.

In pm-user-image.inc line 13, your wrapping <strong> tags inside your t function, these/ all HTML tags should be separated out like so,

$form['#prefix'] = "<div class='pm-user-image-desc'><strong>" . t('Image settings for the image to be shown in private message user auto complete.') . "</strong></br></br>";

In pm_user_image.module line 78, please add some documentation for your autocomplete hook. HOOK_privatemsg_autocomplete.

In pm_user_image.module line 137, you don't need to underscore your hook permission name & maybe a description would be nice.

/**
 * Implements hook_permission(). 
 */
function pm_user_image_permission() {
  return array(
    'administer pm user image' => array(
      'title' => t('Administer Private Message User Image settings'),
    ),
  );
}

Your tpl file seems to have a lot of PHP, almost only PHP. I would try and separate this a little better only passing the required variables to your theme file.

Cheers,

Updated status.

manual review:

1. pm_user_image_init(): why do you need hook_init() which is run on every single page request? Just implement a privatemsg form alter and your CSS as #attached to the form array?
2. pm_user_image_theme(): all your theme functions or templates need to be prefixed with your module's name.
3. pm-user-image-output.tpl.php: no need to use check_plain() for height and width in the first case, the various image theming function will take care of sanitization of attributes. And you should use theme image for the else case as well.

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to patrickd as he might have time to take a final look at this.

Your project page description is very short.. also you could provide an actual link to the private message module.

There's already a tag "7.x-1.0" for an old state of your code. I suggest you delete it and re-tag the most current code with something like "7.x-1.0-beta1" shortly before you actually create the release.

The readme looks much better then your project page - but do you really think people will take a look at the readme rather than on the project page? Maybe you could try to keep their contents the same

Rather use preprocess-hooks and if possible try to put as few PHP code as possible into your tpl-files and functions. Many themers don't know PHP so well and when they need to override your php file you make it very hard for them if there's so much code there.

1 => t('External'),
Use constants with self describing names instead of numbers where appropriate.

Beside the issues klausi pointed out I couldn't find anything critical either, therefore this looks ready to go.

Thanks for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.