Cache plugin, Undefined index 'data' [#2083151]

When the cache module calls `restore_headers` it will sometimes throw an error:
Notice: Undefined index: data in views_plugin_cache->restore_headers() (regel 240 van /home/..../sites/all/modules/contrib/views/plugins/views_plugin_cache.inc).

This is caused due to an assumption that $args['data'] is set.

Comment	File	Size	Author
#5	views-undefined_index_data-2083151-5.patch	864 bytes	erik frèrejean
#4	views-undefined_index_data-2083151-4.patch	863 bytes	erik frèrejean
#1	views-undefined_index_data-2083151-1.patch	602 bytes	erik frèrejean

Comments

Comment #1

erik frèrejean

Dutch

🏴‍☠️

commented 6 September 2013 at 07:32

Status	File	Size
new	views-undefined_index_data-2083151-1.patch	602 bytes

I've attached a patch that will check whether $args['data'] is actually set before calling drupal_add_js().

Comment #2

erik frèrejean

Dutch

🏴‍☠️

commented 6 September 2013 at 07:32

Status:

Active

» Needs review

Comment #3

CSoft commented 19 September 2013 at 19:00

Status:

Needs review

» Needs work

What about css? I have two such errors instead of one.

Necessary to supplement the patch:

if (!empty($this->storage['css'])) {
  foreach ($this->storage['css'] as $args) {
    if (!empty($args['data'])) {
      drupal_add_css($args['data'], $args);
    }
  }
}