system.module: Update use of icons to new standards

...less vague title (there are at least 3 issues with the same name: #2075949-10: Add Libricons to messages).

tagging

Replacing the icons on the system.admin.css by the libricon icons. (The draggable icon in system.module.css is not changed.)

+++ b/core/modules/system/css/system.admin.css
@@ -214,10 +223,16 @@ table.system-status-report td.status-icon div {
+  background-image: url(../../../misc/e29700/warning.png);

Looks like these paths are missing the ‘icons’ folder

Added more info

Oh, that's true. I fix it.

I changed one more icon in the system.module.css file and fixed the bad url path on the system.admin.css file.

Reviewing...

Patch applies well and new SVG icons are loaded. Seems to be a RTBC for me :)

Looks good to me too!

Committed and pushed to 8.x. Thanks!

Followup!

* These png fallbacks had not been optimized, and now have been run through ImageOptim.

* In system.module.css -
The move icon (drag handle) is positioned poorly. This patch improves this and cleans up the related css, including removing a corresponding RTL ruleset where there was no direction specific property/values.

Before

After

* Fixed a place in both system.admin.css and system.module.css where "png" was accidentally "svg".

* In system.admin.css -
Removed LTR comments on icon bkg css that were not direction specific (but hadn't had corresponding RTL css added anyway).

* Corrected one instance of missing RTL css that was legitimately missing and removed an obsolete ruleset.

It looks like the drag icons disappear on hover :(

#13, They did before i patched this. I thought it was intentional because when hovering, the icon is replaced by the "drag handle" cursor. Setting back to needs review to move this along.

Edit: I just checked and this is how the drag handles work on the menu interface, so if it's a bug, it's broader and I believe deserves a new issue.

Ah you're right, I had a look on iPads because I remember doing a fair amount of touch specific styling in #1261002: Draggable tables do not work on touch screen devices.

It needs a little bit of work. I think we can increase the size of the image on touch, which we couldn't do before because it was not SVG.

@LewisNyman, so isn't #15 still another issue? I checked on my iPad and the menu admin screen as in your screenshot is identical before and after #12 patch. To be clear, in #11 a patch got committed, and my followup #12 patch is for optimizing the png fallbacks, drag handle positioning (non touch), and css cleanup. Shouldn't this just go through even if it doesn't address an additional issue, nor cause that issue?

Yep my mistake. I'll do one more review when I get time.

#12: system_module_libricons-2083947-12.patch queued for re-testing.

I'm happy with the code fixes here. Thanks @echoz!

Added test pages

Committed ea232c3 and pushed to 8.x. Thanks!

Fixed the following on commit

git pre-commit check failed: file core/misc/icons/787878/key.png should be 644 not 755
git pre-commit check failed: file core/misc/icons/bebebe/key.png should be 644 not 755