Unit test for the Drupal\serialization\Normalizer\ListNormalizer class.

Files: 
CommentFileSizeAuthor
#3 interdiff-2083983-3.txt746 bytesdamiankloip
#3 2083983-3.patch4.92 KBdamiankloip
PASSED: [[SimpleTest]]: [MySQL] 58,885 pass(es).
[ View ]
d8.XmlEncoderTest.patch4.84 KBdamiankloip
PASSED: [[SimpleTest]]: [MySQL] 58,950 pass(es).
[ View ]

Comments

Status:Active» Needs review

  1. index 1f25389..3b19a44 100644
    --- a/core/modules/serialization/lib/Drupal/serialization/Encoder/XmlEncoder.php
    --- a/core/modules/serialization/lib/Drupal/serialization/Encoder/XmlEncoder.php
    +++ b/core/modules/serialization/lib/Drupal/serialization/Encoder/XmlEncoder.php

    Any reason to keep the code in the constructor?

  2. +++ b/core/modules/serialization/tests/Drupal/serialization/Tests/Encoder/XmlEncoderTest.php
    @@ -0,0 +1,103 @@
    +/**
    + *
    + */

    That is pure nihilism.

+++ b/core/modules/serialization/tests/Drupal/serialization/Tests/Encoder/XmlEncoderTest.php
@@ -0,0 +1,103 @@
+  }
+
+
+}

A bits too much whitespace.

StatusFileSize
new4.92 KB
PASSED: [[SimpleTest]]: [MySQL] 58,885 pass(es).
[ View ]
new746 bytes

Thanks for the review! I've made those changes, except...

Any reason to keep the code in the constructor?

I think it's just a confusing diff, because the constructor has been completely removed :)

Status:Needs review» Reviewed & tested by the community

Ha!

Status:Reviewed & tested by the community» Fixed

Committed 29dd37a and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.