Follow-up from #1840980: [meta] Bootstrap 3.0.

CommentFileSizeAuthor
#8 Screenshot from 2013-09-20 23:45:12.png22.23 KBkslonka
#7 bootstrap-update-and-recompile-2084331-7.patch12.91 KBmarkhalliwell
#7 interdiff.txt11.39 KBmarkhalliwell
#2 recompile_overrides_2084331_3.patch1.76 KBdenes.szabo

Comments

heylookalive’s picture

heylookalive commented

Can someone explain the overrides that are currently in place? I've found a few bits which are off but I don't want to wade in and disrupt legacy things without knowing why they're there first. Also where's the less file?

  • Checkbox & radio button label line height
  • Autocomplete textfield spinner position
  • Password strength meter position
  • Negative margin on .help-block, .control-group .help-inline isn't needed

Could also improve the autocomplete drop down to look a bit nicer too.

denes.szabo’s picture

denes.szabo commented
Status: Active » Needs review
StatusFileSize
new recompile_overrides_2084331_3.patch1.76 KB

I just attached my version. I started to work on the bootstrap3 subtheme, my lessc just found a few missing variables. I replaced them according to the variables.less. Maybe, I did not clearly understand the bootstrap theme (naming conventions, etc), but I hope, my little work helps.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs review » Needs work

@Denes.Szabo thanks for the patch! This certainly helps get us on the right path, but still a lot of work to do on this issue :)

denes.szabo’s picture

denes.szabo commented

Yeah, I agree…

Have you any vision/plan, what, how? I have a little time now, so I can work on it.

markhalliwell’s picture

markhalliwell
Primary language English
commented

In reality, this issue should be the last one to patch (IMHO). We won't necessarily know what other issues could affect this one, until we're close to an RC.

markhalliwell’s picture

markhalliwell
Primary language English
commented

Marked #2093937: Missing variable declarations in bootstrap_subtheme as a dup of this issue.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt11.39 KB
new bootstrap-update-and-recompile-2084331-7.patch12.91 KB

Here is the rest of what I can tell needs to be updated (so far). Also compiled it.

kslonka’s picture

kslonka commented
StatusFileSize
new Screenshot from 2013-09-20 23:45:12.png22.23 KB 
+++ b/bootstrap_subtheme/less/overrides.less
@@ -173,12 +162,11 @@ input, textarea, select, .uneditable-input {
   height: auto;

height: auto; causes firefox to render this incorrectly. Do we really need that?

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Probably not, no. They've changed their styling, obviously, so I'll remove it. We can always put it back in/modify it if needed. I'll add this fix after patching.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed #7:7660918 to 7.x-3.x.
Committed #8:f5b7f0f to 7.x-3.x.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Version: 7.x-3.x-dev » 7.x-3.0-beta1
kslonka’s picture

kslonka commented

We should remove @media @normal, @wide from body styling because we use navbar that is fixed on top as default. (it should always have padding-top)

@media @normal, @wide {
    padding-top: 60px;
  }
markhalliwell’s picture

markhalliwell
Primary language English
commented

@kslonka, open new issues please.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.