This is my first patch ever on Drupal.org and I'm combining 2 patches in the issue queues for this module b/c it's getting tricky to keep them all sorted (row #'s are changing) without a combined update. I'm hoping the maintainer/community will test and roll this soon to get these issues merged into a stable(r) dev release.

Solving two issues with 2 patches

Issue #1 - Support for multiple fields

Applied this patch: https://drupal.org/node/1464950#comment-7197278

Issue #2 - field collections within other field collections do not function when set as dependents

Applied this patch: https://drupal.org/node/1648128#comment-6577266

Solving these 2 Issues/Applying 2 Patches Solves for this Use Case

  • I have a content type with a field collection named A that is a multi-value field.
  • Field collection A has 4 fields: (#1) a term reference field, two link fields (#2 and #3), and another field collection within it named B.
  • Field collection B is composed of two text fields (#3 and #4).
  • Within field collection A I have a term reference field (#1) set up as the dependee field for #2, #3, and B, where they are "...visible when Video Source has value "Term IDs" (setup for unique IDs for each dependent).

INTENDED RESULT: This use case hides 1 and 2 appropriately until their assigned terms are selected in the taxonomy term selector, but won't hide B by default. You can add multiple values for A and these behaviors are maintained.

OUTCOME OF APPLYING 2 PATCHES: It seems stable and working. Please confirm and please help push to a release.

CommentFileSizeAuthor
[multi-and-nested]-[multi-value-fields-and-nested-collections-dual-fix]-[new]-[1].patch22.99 KBMO-2
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented
Status: Needs review » Closed (duplicate)

Hey Matt, I appreciate your enthusiasm, but this is not how we do things in Drupal. Each problem gets its own issue and its own isolated patch that solves that specific issue. The more complex a patch/issue is, the less chances it has to be committed. If you want to see your issues fixed, then you must follow the following path:

1. thoroughly review a patch in an issue that is set to "needs review".
2. provide evidence that the patch solves the issue without causing any additional issues.
3. get others to verify that the patch works and perhaps use the patch in a production environment for some time.
4. set the issue in a "reviewed & tested by the community" status (also known as RTBC) - steps #2 and #3 above satisfy the "tested by the community" part.
5. patiently wait for the module maintainers to find time to verify this and commit if they agree with the solution.

Let me say at this point that it is very common for module maintainers to request an actual code review (to satisfy the "reviewed" part) and thus revert issues that are set to RTBC back to "needs review". Also keep in mind that "pushing" for commit doesn't necessarily mean you'll get what you are after sooner - sometimes it causes the opposite result because it pisses off module maintainers. As I said in step #5 be patient because things take time.

In the mean time, you do have the patches available so, patch the modules that have the issue(s) and wait.

As for "combined" patches, I'm afraid they don't stand much chance. See #1896326-11: Combined patch for all known issues in D7 branch for example. You might also want to take a read at the Diaries of a Core Maintainer #1: The Danger of Patch Context Switching written by Angela "Angie" Byron (drupal nickname: "webchick") which is a Drupal core committer and co-maintainer. She is also considered to be the "second in command" after Dries Buytaert (founder and lead developer of Drupal), so she knows what she's talking about when she says:

We've all been there. You sit down to write a "simple" patch. Maybe it upgrades a module to Drupal 6. Maybe it adds a small feature, or fixes a bug that's been annoying you for awhile.

... You search through the file for the lines you need to change and... Suddenly your "simple" patch has grown into 30-40K of changes. It fixes the original thing you set out to fix, and it also makes several improvements to the code that you found as you were going through. Great! So what's the problem?

...

When you upload that horrendous, multi-headed, kitten-eating monster of a patch ...reviewers need to find more like 45 minutes or an hour between things, which is much harder to come by during the run of a day. ...

So please, when you upload patches, try to keep them to one "context" at a time (feature X, bug fix Y, minor cleanup, etc.)....

I hope I've explained why this issue needs to be closed as a duplicate of #1464950: Support for multiple "Field collection" and "Multifield" fields and #1648128: field collections within other field collections do not function when set as dependents.