The current way of hiding the comments, and rendering it at the block breaks the pager in other modules.
Quick to reproduce: use a view, list of rendered nodes.

I figured out how it can be done better, included is a patch. It is not complete, other functionality of the module does not work, but it is a start point to make the code cleaner.

CommentFileSizeAuthor
#1 1513910-fix-pager-issue-at-commentsblock.patch3.01 KBerlendoos

Comments

erlendoos’s picture

erlendoos commented
StatusFileSize
new 1513910-fix-pager-issue-at-commentsblock.patch3.01 KB
erlendoos’s picture

erlendoos commented
Issue summary: View changes

better description of the issue

marcoka’s picture

marcoka commented

would this still work with: #1952438: Strict warning: Only variables should be passed by reference in commentsblock_block_view() (line 98 of as the new version will not use drupal_render anymore

marcoka’s picture

marcoka commented

ok i teste this with the new version.
http://i.imgur.com/IZnMkMO.png

i have my comments and my pager, and the pager works. i lost track of what the actual bug report from the other issue was.

deanflory’s picture

deanflory commented
Issue summary: View changes

Patch fails when applied to commentsblock-7.x-2.5

patching file commentsblock.module
Hunk #2 FAILED at 103.
Hunk #3 FAILED at 151.
2 out of 3 hunks FAILED -- saving rejects to file commentsblock.module.rej

Is this still an issue after so much time has passed?

marcoka’s picture

marcoka commented

it should already be in 2.5 and work there. do you have taht issue with 2.5?

deanflory’s picture

deanflory commented

So, should this issue be closed?

marcoka’s picture

marcoka commented

if it works with the latest version. yes we should close it.

erlendoos’s picture

erlendoos commented
Status: Needs review » Fixed

Confirmed! Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.