Currently, pane titles are displayed only using the 'default' view mode settings. They should be displayed according to the specified view mode.

So if my 'default' view mode has the 'title' set to visible, and my 'full - no title' view mode has 'title' set to hidden, I do not want title to be displayed when the pane has 'full - no title' set.

CommentFileSizeAuthor
#5 fieldable_panels_panes-n2092477-5.patch1.68 KBdamienmckenna
#2 fieldable_panels_panes-title_use_view_modes-2092477-2.patch1.21 KBrrrob
#1 fieldable_panels_panes-title_use_view_modes-2092477-1.patch995 bytesrrrob

Comments

rrrob’s picture

rrrob commented
Status: Active » Needs review
StatusFileSize
new fieldable_panels_panes-title_use_view_modes-2092477-1.patch995 bytes

Patch attached.

rrrob’s picture

rrrob commented
StatusFileSize
new fieldable_panels_panes-title_use_view_modes-2092477-2.patch1.21 KB

This new patch fixes a condition I missed the first time.

mkhamash’s picture

mkhamash commented
Issue summary: View changes

Confirm that the patch does work with display suite title field and the logic seems ok, but the code does need some cleaning-up.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2244541: [meta] Plan for Fieldable Panels Pane 7.x-1.6 release
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new fieldable_panels_panes-n2092477-5.patch1.68 KB

+1 one for this, though I've added a quick !empty($entity->title) before doing the other logic.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

  • DamienMcKenna committed 5abfc67 on 7.x-1.x 
    Issue #2092477 by rrrob, DamienMcKenna: Make the pane title use the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.