Updated: Comment #60
The field_attach_form_*() functions:
- are old D7-style functional code
- live in field.module but are called from Core/Entity, which is backwards
- are still formulated in the old entity translation model (receive an $entity and a $langcode)
- are still largely based on code that predates EntityNG / Entity translation (convoluted field_invoke() / field_invoke_method() iterators)
Replace them by simple iterators in EntityFormDisplay objects, that assume that multilingual logic has been resolved upstream.
See #30 / #31 / #40 for discussion leading to EntityFormDisplay.
(obsoletes a previous approach that placed the methods in a new ContentEntityFormHelper service - see #20-#23 for discussion about this former approach)
Current patch still implements the previous approach (ContentEntityFormHelper).
Branch field_attach-remove-2095195-service in the sandbox
The new approach based on EntityDisplays is being developped on the "entity view" side in. Once that one is validated (committed or RTBCed), the patch here can be updated accordingly. Task is postponed meanwhile.
User interface changes
|PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 65,055 pass(es).|
|FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch field_attach-remove-2095195-80.patch. Unable to apply patch. See the log in the details link for more information.|
|PASSED: [[SimpleTest]]: [MySQL] 64,533 pass(es).|