Closed (fixed)
Project:
Drupal.org customizations
Version:
7.x-3.x-dev
Component:
User interface
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
25 Sep 2013 at 20:33 UTC
Updated:
23 May 2014 at 18:23 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #1
Bojhan commentedNo, this is actually by design - click the huge Update this issue.
Comment #2
jthorson commentedPositioning as a feature request, and tagging for discussion.
Comment #3
andypostAt least comment body needs more rows by default
Comment #4
jthorson commentedComment #5
tvn commentedClosed #2098091: There *must* be a way to easily update an issue from the comment form. as duplicate of this one.
Our options include:
1. Make 'issue details' block sticky
2. Repeat 'issue details' block at the bottom (which will look ugly when both blocks are visible on the screen e.g. when there are no comments)
3. Add 'Update this issue' link next to the comment form.
Comment #5.0
tvn commentedupd
Comment #6
jthorson commentedI think the motivation behind this issue was to put the 'full' edit issue form (complete with metadata and file upload) on the issue page itself instead of behind another mouse click ... not simply moving/duplicating the 'update this issue' button.
Comment #7
tvn commentedIn that case it should've been closed as (works as designed) after the first comment. We still need to make it more obvious how to update issues now, so let's continue here instead of closing this issue and re-opening the other one.
Comment #7.0
tvn commentedimg
Comment #8
tvn commentedDuring D7 team call today we settled on adding "Update this issue" link next to the comment form. Changing title accordingly.
Comment #8.0
tvn commented.
Comment #9
tvn commentedMockup:

Or we could even have 2 different links - Update this issue and Upload new file.
It might be not too obvious that one needs to update an issue in order to upload a file. On the other hand less links, less choices to make.
Comment #10
jthorson commentedComment #11
jthorson commentedOkay ... this took a couple steps, since the 'Add this comment' is hard-coded directly within the comment-wrapper template.
The Bluecheese patch modifies this to output $variables['comment_form_title'] in the template, and defines this as the default 'Add new comment' text within bluecheese_preprocess_comment_wrapper().
The drupalorg patch then sets it's own $variables['comment_form_title'] value, adding the 'Update this issue' link within it's own preprocess_comment_wrapper() call.
Comment #12
jthorson commentedComment #13
jthorson commentedScreenshot from dev site, with patches applied.
Comment #14
helmo commented+1, looks better
Comment #15
drummI'm not too fond of making any PHP additions in bluecheese, but this is temporary. Committed & deploying.
Comment #16
drummForgot to untag. We're not really in a hurry, so this isn't even Drupal.org 7.1.
In the meantime, we can think about:
Comment #17
jthorson commentedYeah ... the bluecheese template was a bit of a head-scratcher. But even more so is the fact that this can't be over-ridden any other way in core ... the text for this title is hard-wired into the .tpl file, whereas we make just about everything else alter-able via hooks.
Comment #17.0
jthorson commentedupd
Comment #18
mgiffordI think this issue needs to be updated.
Can we close this issue and create follow-up issues for the Google Analytics? Would be great to have stats on what folks are actually doing.
I like the idea about pointing to new UI changes in drupal.org. But again that should be a new issue.
Comment #19
drummThis was rolled into #2159813: Display parts of the issue edit form instead of the comment form on issue pages.