Closed (fixed)
Project:
Fieldable Panels Panes (FPP)
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 Sep 2013 at 22:18 UTC
Updated:
6 Jan 2015 at 21:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jagilpe commentedIs there any update to this issue? We have a problem with the title translation of fieldable panels panes, and the only logical solution that we've found is to remove one of the hook_entity_presave calls, but we would like to know if there is a reason to call this hook twice, to be sure that it's safe to remove one.
Comment #2
alcroito commentedI've investigated the code in other entity modules to see whether any-one else invokes the 'entity_presave' hook twice, and that does not seem the case.
The only reason I think that the second call was added, was to re-execute uuid_entity_presave, so it regenerates the vuuid key, after the old vid was removed.
But I think that is erroneous and it is not necessary, if you look at node_save() it also first calls hook_entity_presave(), and afterwards unsets the vid key, without calling the hook a second time.
Comment #3
alcroito commentedAttaching a patch that removes the second invocation to hook_entity_presave().
Comment #4
damienmckennaComment #6
damienmckennaCommitted. Thanks!