This module is a plugin for Addressfield. It provides an user friendly Colombia address form with states and cities. When you select colombia it shows the colombian states and the cities that belongs to every state depending on the selected state through ajax. To test you must go to field edit to check "Address form (specific for Colombia)" to use.

Project Page:

https://drupal.org/sandbox/pixelula/2099879

Git repo

git clone http://git.drupal.org/sandbox/pixelula/2099879.git

Comments

el_toro’s picture

Hi pixelula,

To get the regular stuff out of the way:
- you should check out the review by pareview and fix those small issues.
- check out these tips for a template on what a good project page looks like.

For my manual review:
- To avoid having that long array of states and cities in a code file that you may have to work on periodically I would suggest you put that array into a variable at install and delete the variable at uninstall. That way when you need the list you can just do variable_get('addressfield_co_states_list', array()). But that's just my opinion on keeping clutter out of your working file. SOmeone else may say different.

- I installed the module and created a test address with the state of Guainía and city of Mapiripana. After saving the node and viewing I just see a value of 94663 which is just a combination of the numeric values you have for the state (94) and city (663) in the select forms.

el_toro’s picture

Status: Active » Needs work
jeroent’s picture

I tested this module, and it works, with one small bug.

The key instead of the value is shown in the when viewing the node.

There is an option render_option_value that solves this problem:

$format['locality_block']['administrative_area']['#render_option_value'] = true;
pixelula’s picture

Hi,

Thanks to @JeroenT and @el_toro for the reviews.

- The codign standards has been fixed Review
- The rendered address has been fixed adding the rendered option suggested by @JeroenT.
- Thanks to @el_toro for his suggestions but I will keep cities and states in code. This arrays keep the same values and IMHO maybe it's better for performance load values from code rather than database.

Thanks

pixelula’s picture

Issue summary: View changes
Status: Needs work » Needs review
PA robot’s picture

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

kscheirer’s picture

Status: Needs review » Postponed (maintainer needs more info)

After a recent discussion with one of the addressfield maintainers we would like to ask you to submit this as patch against the core addressfield module instead. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition.

If your patch is accepted please close this project application and feel free to come back to us whenever you have a new project to promote.

If your patch is rejected for whatever reason please revert the status of this project application and add a section to the issue summary where you explain why this could not go into addressfield core directly. And a link to the issue in the addressfield issue queue where that was discussed would be nice in the issue summary.

----
Top Shelf Modules - Crafted, Curated, Contributed.

PA robot’s picture

Status: Postponed (maintainer needs more info) » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.