Closed (fixed)
Project:
Node Accessibility
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
30 Sep 2013 at 20:19 UTC
Updated:
16 Oct 2014 at 02:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
hefox commentedAlong the same vein, why load the settings into the node object? It's a per type setting.
Comment #2
thekevinday commentedThat should be more efficient.
I suspect that while I had my mind on writing node settings, I mentally merged the node-type settings (which are not needed to be on a per node basis).
I believe the reason I placed the settings in the node is to utilize the objective-oriented-ness of nodes.
Still, it would save memory for an arbitrarly large number of nodes for the settings that don't need to be on a per-node basis.
So, I will work on fixing this.
Comment #3
thekevinday commentedAfter looking at the code again, I remembered what I was doing.
I did not use the variable system intentionally so that I could more fully utilize the SQL.
The variable system is convenient for coding, but it is neither efficient nor flexible/extensible.
In particular, I avoid string comparisons and joins everywhere possible.
However, as I do not see the current design of node_accessibility advancing further (now with the shiny new accessibility module in place), I might as well simplify the design.
I will have to review the views SQL functionality to see if I can change this or not.
I do not want to break the views SQL integration, so if that causes a problem, then I will leave the SQL code as is.
However, I will change the code to be pulled on a per node_type basis as opposed to a per node basis.
Comment #4
thekevinday commentedand heres the patch for review.
Comment #5
thekevinday commentedComment #6
thekevinday commentedI missed a change.
Please review this patch.
Comment #7
thekevinday commentedNo response and as far as my testing goes, this is fixed.