I can't think of any other module that uses database table for simple node type settings. Cannot export settings via strongarm.

Comments

hefox’s picture

Along the same vein, why load the settings into the node object? It's a per type setting.

thekevinday’s picture

Assigned: Unassigned » thekevinday

That should be more efficient.

I suspect that while I had my mind on writing node settings, I mentally merged the node-type settings (which are not needed to be on a per node basis).

I believe the reason I placed the settings in the node is to utilize the objective-oriented-ness of nodes.
Still, it would save memory for an arbitrarly large number of nodes for the settings that don't need to be on a per-node basis.

So, I will work on fixing this.

thekevinday’s picture

After looking at the code again, I remembered what I was doing.

I did not use the variable system intentionally so that I could more fully utilize the SQL.
The variable system is convenient for coding, but it is neither efficient nor flexible/extensible.
In particular, I avoid string comparisons and joins everywhere possible.

However, as I do not see the current design of node_accessibility advancing further (now with the shiny new accessibility module in place), I might as well simplify the design.

I will have to review the views SQL functionality to see if I can change this or not.
I do not want to break the views SQL integration, so if that causes a problem, then I will leave the SQL code as is.

However, I will change the code to be pulled on a per node_type basis as opposed to a per node basis.

thekevinday’s picture

StatusFileSize
new19.48 KB

and heres the patch for review.

thekevinday’s picture

Status: Active » Needs review
thekevinday’s picture

StatusFileSize
new20.26 KB

I missed a change.
Please review this patch.

thekevinday’s picture

Issue summary: View changes
Status: Needs review » Fixed

No response and as far as my testing goes, this is fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.