Subtask of #1830588: [META] remove drupal_set_title() and drupal_get_title()

Problem/Motivation

Using procedural drupal_set_title() inside controller class is not encouraged.

Proposed resolution

Replace drupal_set_title() with #title in page return array.

Remaining tasks

Issue patch

User interface changes

Refer parent issue at #1830588: [META] remove drupal_set_title() and drupal_get_title()

API changes

Refer parent issue at #1830588: [META] remove drupal_set_title() and drupal_get_title()

CommentFileSizeAuthor
#11 drupal-remove-drupal_set_title-from-translation-2102445-11.patch1.52 KBwebwarrior
#3 drupal8.content-translation.module.2102445-3.patch978 bytesdisasm

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
commented

blocked by #1987882: Convert content_translation routes to a new style controller

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Active » Postponed
disasm’s picture

disasm commented
StatusFileSize
new drupal8.content-translation.module.2102445-3.patch978 bytes

this shouldn't conflict with the conversion. One line fix to get the remaining drupal_set_title removed.

cameron tod’s picture

cameron tod commented
Status: Postponed » Needs review
dawehner’s picture

dawehner
Primary language German
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Perfect!

dawehner’s picture

dawehner
Primary language German
commented

3: drupal8.content-translation.module.2102445-3.patch queued for re-testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

3: drupal8.content-translation.module.2102445-3.patch queued for re-testing.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

as per #5, back to RTBC.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

webwarrior’s picture

webwarrior commented
Status: Closed (fixed) » Needs review
StatusFileSize
new drupal-remove-drupal_set_title-from-translation-2102445-11.patch1.52 KB

Removed the drupal_set_title from overview page.

Also now displays the more user friendly title. Don't know if there was a decision made to only display "Translate" as title for that page?

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs review » Reviewed & tested by the community

Looks good, thanks

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Not sure; looks like an oversight to me. Nice catch!

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.