[D7] Sir Bones - Theme

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxdubcanada1925000git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Thank you for your reviews. When finishing your review comment also set the issue status either to "needs work" (you found some problems with the project) or "reviewed & tested by the community" (you found no major flaws).

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
Review of the 7.x-0.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. sirbones_preprocess_page(): doc block is wrong, see https://drupal.org/node/1354#hooks . Same for the file docblock, see https://drupal.org/node/1354#files
2. "Inline control structures are not allowed" means that you must use curly braces with if statements.
3. This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to kscheirer as he might have time to take a final look at this.

Regarding the inline control structures in #2, this:

  if($block->subject) print '<h2 class="block-title"' . $title_attributes . '>' . $block->subject . '</h2>'; 

should be

  if ($block->subject):
    print '<h2 class="block-title"' . $title_attributes . '>' . $block->subject . '</h2>';
  endif;  

So it's not all on 1 line. See https://drupal.org/coding-standards#controlstruct, under "Alternate control statement syntax for templates".

The 7.x-0.x should really be named 7.x-1.x
@file docs need to be added to most of the files, see https://drupal.org/coding-standards/docs#file.
There should be no master branch.

----
Top Shelf Modules - Crafted, Curated, Contributed.

https://drupal.org/project/sirbones

Thanks for your contribution, dubcanada!

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.