When adding the 2nd row using "Add Another", the headers get messed up and the row weights field appears - see attached.

CommentFileSizeAuthor
#15 field-collection-table-headers-2104475-4.patch613 bytesalx_benjamin
#3 field-collection-table-headers-2104475-3.patch3.7 KBrobcarr
#1 issue_2104475.patch3.69 KBblainelang
broken_headers.jpg33.94 KBblainelang
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

blainelang’s picture

blainelang CreditAttribution: blainelang commented
Status: Active » Needs review
FileSize
issue_2104475.patch3.69 KB

Attached is a patch against DEV that fixes this as well as a NOTICE error that occurs.

blainelang’s picture

blainelang CreditAttribution: blainelang commented

There is also a related issue here: https://drupal.org/node/1780394

robcarr’s picture

robcarr
Primary language English
Location Perthshire, Scotland
CreditAttribution: robcarr commented
Issue summary: View changes
Related issues: +#1780394: The table header disappear when there is a validation errorHeader
FileSize
field-collection-table-headers-2104475-3.patch3.7 KB

For some reason the patch at #1 wouldn't apply for me, so attached a re-roll. I'm getting lots of corruption of the table if the 'Hide blank items' option is selected on the parent content type (including the headers). The patch hasn't completely solved this issue (which seems to be related to the draggable rows column).

anon’s picture

anon
Primary language Swedish
Location Gothenburg
CreditAttribution: anon commented

Patch in #3 works fine for me.

The table now renders perfect. Haven't test it on any other configurations except just using the table widget.

brandy.brown’s picture

brandy.brown CreditAttribution: brandy.brown commented

Patch in 3 worked for me too. Also solved another issue I was having of it adding random empty table rows.

I'm pretty sure this patch also solved https://drupal.org/node/1945998, but would need someone else to make sure that's true.

Thanks!!

entornos.abiertos’s picture

entornos.abiertos CreditAttribution: entornos.abiertos commented

Patch in #3 also works fine for me.

Thanks!

robcarr’s picture

robcarr
Primary language English
Location Perthshire, Scotland
CreditAttribution: robcarr commented
Status: Needs review » Reviewed & tested by the community
xandeadx’s picture

xandeadx CreditAttribution: xandeadx commented

#3 works for me

slimedidi’s picture

slimedidi CreditAttribution: slimedidi commented

#3 works for me!
but is that possible bundle with Ignores Field Access issue's patch?

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
CreditAttribution: kristiaanvandeneynde commented

@slimedidi: You generally shouldn't combine two issues into one patch.

slimedidi’s picture

slimedidi CreditAttribution: slimedidi commented

@kristiaanvandeneynde : yap! I try to do that but failed....so I'm wondering if anyone have the same problem.....

lucidwayn’s picture

lucidwayn CreditAttribution: lucidwayn commented

#3 needed an extra "}" for version - field_collection_table 7.x-1.0-beta2
Seemed to do the trick through once patch + extra parenthesis was added.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
CreditAttribution: darvanen commented

Could not replicate on a fresh site using dev version - has this been committed already? or fixed by another patch?

maximpodorov’s picture

maximpodorov CreditAttribution: maximpodorov commented

@kevineinarsson, is this issue fixed by the recent commits?

alx_benjamin’s picture

alx_benjamin CreditAttribution: alx_benjamin commented
FileSize
field-collection-table-headers-2104475-4.patch613 bytes

Couldn't apply patch #3 in its entirety.
So here is a separate patch to address
theme_field_collection_table_multiple_value_fields().

  • kevineinarsson committed fe9e86e on 7.x-1.x authored by arrrgh 
    Issue #2104475 by blainelang, arrrgh: Broken headers after Add Another
kevineinarsson’s picture

kevineinarsson CreditAttribution: kevineinarsson commented
Status: Reviewed & tested by the community » Fixed

Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.