I was tying to change default git branch and got this error message.
Strict warning: Only variables should be passed by reference in versioncontrol_project_git_default_branch_form_submit() (line 53 of /var/www/git-dev.drupal.org/htdocs/sites/all/modules/versioncontrol_project/versioncontrol_project_git/versioncontrol_project_git.pages.inc).

CommentFileSizeAuthor
#5 versioncontrol_project-2104823-5.patch754 byteschi
#3 versioncontrol_project-2104823-2.patch755 byteschi
#1 versioncontrol_project-2104823-0.patch790 byteschi

Comments

chi’s picture

chi commented
Status: Active » Needs review
StatusFileSize
new versioncontrol_project-2104823-0.patch790 bytes
marvil07’s picture

marvil07 commented
Status: Needs review » Needs work

@Chi: Thanks, this is probably old code. Now we have a VersioncontrolRepository::loadBranch() method too, would you like to change the call?

chi’s picture

chi commented
Status: Needs work » Needs review
StatusFileSize
new versioncontrol_project-2104823-2.patch755 bytes

I didn't test it manually

marvil07’s picture

marvil07 commented
Status: Needs review » Needs work

Docs at http://drupalcode.org/project/versioncontrol.git/blob/19ee3e12ed4dc4f9e3...

chi’s picture

chi commented
Status: Needs work » Needs review
StatusFileSize
new versioncontrol_project-2104823-5.patch754 bytes
marvil07’s picture

marvil07 commented
Status: Needs review » Fixed

Thank you!

Added to 7.x-1.x.

Automatically closed -- issue fixed for 2 weeks with no activity.