Field is not showing up in entity view page

The problem is that hook_field_info defines 'default_formatter' as 'entityreference_count_formatter_default', which doesn't exist. However, just renaming both formatters will cause problems for anyone currently using the module, so I believe this approach would work better.

Also, please don't forget to change the status to "needs review" when you upload a patch. Thanks!

There should be a way to handle this with an update function. Having that bc case there feels hacky to me. I'd like to see what I can dig up before settling on this option.

I'm thinking something like this in the .install file should do it:

function entityreference_count_update_7100() {
  $fields = field_read_fields(array('type' => 'entityreference_count'));
  foreach ($fields as $field_name => $info) {
    $full_info = field_info_field($field_name);
    foreach ($full_info['bundles'] as $type => $bundles) {
      foreach ($bundles as $bundle_name) {
        $field_instance_info = field_info_instance($type, $field_name, $bundle_name);
        foreach ($field_instance_info['display'] as $display) {
          if ($display['type'] == 'entityreference_count_default') {
            $display['type'] == 'entityreference_count_formatter_default';
          }
        }
      }
    }
  }
}

What's missing is a way to then save that change.

Ok, this should take care of actually saving the change:

function entityreference_count_update_7100() {
  $fields = field_read_fields(array('type' => 'entityreference_count'));
  foreach ($fields as $field_name => $info) {
    $full_info = field_info_field($field_name);
    foreach ($full_info['bundles'] as $type => $bundles) {
      foreach ($bundles as $bundle_name) {
        $field_instance = field_info_instance($type, $field_name, $bundle_name);
        foreach ($field_instance['display'] as $display_name => $display) {
          if ($display['type'] == 'entityreference_count_default') {
            $field_instance['display'][$display_name]['type'] = 'entityreference_count_formatter_default';
          }
        }
        field_update_instance($field_instance);
      }
    }
  }
}

Patch to follow when I get a chance.

And, patch attached. This takes care of all the cases from the original patch, as well as the new formatter defined in #2572811: Provide options for link and label in default field formatter.

Now with less unnecessary whitespace, lol.

And rerolled due to a number of recent commits.

Tested the update a bunch of times and all seems good. Thanks everyone.