Closed (duplicate)
Project:
Drupal core
Version:
8.0.x-dev
Component:
action.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
6 Oct 2013 at 18:23 UTC
Updated:
29 Jul 2014 at 23:01 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
vijaycs85Comment #2
vijaycs85Initial patch...
Comment #3
vijaycs85changing int to bool...
Comment #4
cosmicdreams commentedIn other patches you use lowercase for boolean statements.
Which should they be uppercase or lowercase. Pick one.
Comment #5
tim.plunkettUppercase.EDIT: chx's point below trumps all other conventions.
Comment #6
chx commentedlowercase. Bring the issue up with the symfony yaml guys. It dumps lowercase.
Comment #7
krishnan.n commented'0' => false, '1' => true. This is only for: config/views.view.test_bulk_form.yml. Will work thru the rest, if this is OK.
Comment #8
krishnan.n commentedPlease provide review feedback on the patch above, and i'll script through the rest of the tree -- thx.
Comment #9
chx commentedYes this looks good! Careful with scripting. Perhaps share the script with us? You can't wholesale search-replace 1 and 0 to true and false, sometimes they are numbers.
Comment #10
krishnan.n commentedScript attached:
Also, how best to walk through directory tree to pick up relevant yml files? This is the rough version:
Better to do the above by hand?
Comment #11
damiankloip commentedGroup should definitely be a number, this is the group used when the condition groups are built for the query. So 1 is the default group here.
Comment #11.0
damiankloip commentedupdating views.view.test_bulk_form.yml
Comment #12
vijaycs85Re-roll...
Comment #13
vijaycs85The patch on this issue has been updated as part of #2167623: Add test for all default configuration to ensure schema exists and is correct. As this issue doesn't have any test to confirm/validate the schema, making this change and closing this issue as duplicate of #2167623: Add test for all default configuration to ensure schema exists and is correct. The contributors of this issue (in commit message) is copied to #2167623: Add test for all default configuration to ensure schema exists and is correct.