Five weeks ago, I became a Co-Maintainer of the Field conditional state module: https://drupal.org/project/field-conditional-state
The current version 2.x is my own creation to almost 100%, but I also contributed to 1.x.
With the Field conditional state module you can set the #state form field attribute based on value selected in other form fields.
The 1.x version is somehwat limited, but the target of the version 2.x is, to create an FAPI states UI for fields, supporting all its possibilities.
Repository:
git clone --branch 7.x-2.x http://git.drupal.org/project/field-conditional-state.git
Now we would like to "rename" the module from field-conditional-state to field_conditional_state (#1905376: Rename your module? - drush issues and #2101553: Roadmap 7.x-1.1 and beyond #7 and following), but according to #1875910: change project URL and git repo path the only possibility is, to create a new project.
Because of that I would like to be able to create a new full project for the 2.x branch of the Field conditional states module.
Comments
Comment #1
PA robot commentedLink to the project page and git clone command are missing in the issue summary, please add them.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #1.0
Tobias Xy commentedgit clone added
Comment #1.1
Tobias Xy commentedChanged clone command
Comment #2
Tobias Xy commentedI added the git clone command, but the link to the project page already exists (it's a full project; no sandbox)!
Comment #3
nitesh pawar commentedThere are some errors reported by automated review tools, did you already check them? See
http://pareview.sh/pareview/httpgitdrupalorgprojectfield-conditional-sta...
Comment #4
Tobias Xy commentedYeah, I did.
But the remaining Errors / Warnings are only about "Line too long" and "Short description in one line".
I don't understand why the short description has to be in a single line? It's sometimes really hard to describe a function within one line and a maximum of 80 characters.
I'll try to fix that, if necessary but I can't see the benefit of this.
Comment #5
bneil commentedHello,
Please provide a README.txt file https://drupal.org/node/447604
This sounds like a really useful module. I was testing it and I'm wondering how you delete conditional states from a field? For example, I no longer want conditionality anymore and I wasn't able to remove any settings from the field.
When deleting a field that another field depended on, I received the following error:
Perhaps there's a graceful way to handle removing a field.
Comment #6
Tobias Xy commentedI completely rewrote the settings form, changed the database design (without update hooks, so please make a clean install!) and fixed the "Undefined index" issue.
Also I added a README.txt.
Should be fine now! :-)
Edit: The only problem reported by the automatic review tool is a false positive, I guess...
Comment #7
masoud561 commentedHi, I reviewed your module manually and I found some Issues:
1- in conditional states tab when a user deletes two or more conditions without refreshing the page,
second delete function doesn’t work correctly.
Tip: Probably because, “$state_id” variable in “field_conditional_state_delete_condition”
Function, doesn’t change for each delete button pressing.
2- name of functions which isn’t public and isn’t hook, like some functions in
“field_conditional_state.admin.inc” file, would be better to begin with an Underscore “_”.
Tip: See drupal.org/node/1118210
3- in conditional states tab after a user clicks on save configurations button, first vertical tab is shown
But it would be better to show last modified tab.
Comment #8
hass commentedTobias asked for a project rename and to create a new project without hyphens. Nobody asked for reviews and coder bullsh** warnings.
Comment #9
hass commentedThis is the wrong place here. Tobi, go into https://drupal.org/project/user and click in the project table the link "Add a new project"... Be careful with the names and tripple check them all before saving finally... Copy over the git code later.
Comment #10
Tobias Xy commentedSince this is only way I know to get the permission to create full projects (I don't want FCS 2.x to be a sandbox project), it's wrong to close this issue.
I'm not happy about this and as long as nobody can present a solution to rename our project, this seems to be the only way.
Comment #10.0
Tobias Xy commentedExtended project description
Comment #11
hass commentedYou mean the link creates a sandbox project only?
Comment #12
hass commentedNo, I can. I could create the project myself. You should also be able to do, too. https://drupal.org/project/add and select module project.
Comment #13
Tobias Xy commentedThe issues mentioned in #7 are fixed now.
@hass: I'm not able to create full projects following your link. I guess you already have the right to create full projects.
Comment #14
hass commentedNo idea why. I can create it for you and give you full access if someone else is not able to grant you the propper permissions for module maintainers.
Comment #15
PA robot commentedGit clone command for the sandbox is missing in the issue summary, please add it.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #16
geek-merlinLooks like this is fixed now.
Reopen if i got that wrong.