Commerce Credit card on Delivery

This module provides an offline payment method for drupal commerce that allows for payments to be made on delivery.

This module is smiler to the following modules:
Commerce Bank Transfer
Commerce Cash on Delivery
Commerce Cheque
However as this needs to be an independent payment option it needs its own module. It is also possible that we may need to add a credit card surcharge and that is likely to be only relevant for card on delivery.
Q: Why not just have a payment on collection method?
A: We need to know in advance that this is a credit card payment so the card reader is available at the point of delivery.

Project page: https://drupal.org/sandbox/guy_schneerson/2110123
git repository: http://git.drupal.org/sandbox/guy_schneerson/2110123.git
Commits: https://drupal.org/node/2110123/commits

I also maintain the Commerce Stock and Commerce decimal quantities and a number of sandbox modules.

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Active » Needs review

I guess this needs review? See https://drupal.org/node/532400

PA robot’s picture

PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

cheatlex’s picture

cheatlex commented

Hi, great module

I did a manual review of you module by installing on a commerce kickstart, everything looks great, and compared to other payment options it works like it should.

One suggestion - though, just tried to do a little test, and I’m not a fan of manual tasks like pushing the “Payment received” button, would rather have a rule to do the same operation and maybe then it could add the transaction number of an external/handheld terminal.

+1

guy_schneerson’s picture

guy_schneerson commented

Hi cheatlex and thanks for your review. I created a Feature request ux improvement for “Payment received” button and will look into it once the module is out of sandbox.

andyhat’s picture

andyhat commented

I have just looked at commerce_ccod.module and README.txt file and only found 1 minor error in the README.

2. Configure the Rule "Credit card on Delivery" via Store > Configuration > Payment settings.

Should be:
2. Configure the Rule "Credit card on Delivery" via Store > Configuration > Payment methods.

guy_schneerson’s picture

guy_schneerson commented
Issue summary: View changes

Thanks andyhat issue fixed https://drupal.org/node/2127427

andyhat’s picture

andyhat commented
Status: Needs review » Reviewed & tested by the community

Thanks for sorting it quickly.
I've pulled the change and checked that it's correct.
The code was tested using http://pareview.sh online automated testing.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Reviewed & tested by the community » Fixed
README.txt
Please take a moment to make your README.txt follow the guidelines for in-project documentation.

Thanks for your contribution, guy_schneerson!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.

alex_sansom’s picture

alex_sansom commented

Installed in my non-kickstart dev environment and this works perfectly.

Having looked throught the code manually, run the Coder module over it and used the pareview site, I cannot find a single issue with this.

guy_schneerson’s picture

guy_schneerson commented

Thanks kscheirer andyhat, cheatlex, alex_sansom for your help

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.