While running tests/functional_tests/aegir2-dev/run-tests.sh the provitioning fails to install hostmaster.

we use drush_set_default(), to set the document root for hostmaster... but this does not work when the process received a '--root=' (no value).

tests/functional_tests/aegir2-dev/modules/aegir/manifests/dev.pp

$platform_path      = false,
...

if $platform_path {     $o = " --root=${platform_path}" }

I don't understand why the --root option gets added. In the meantime I've added a quickfix patch for provision to handle this.

CommentFileSizeAuthor
puppet-aegir-provision-quickfix.patch785 byteshelmo

Comments

helmo’s picture

helmo commented

Hmm, same error when the whole 

if $platform_path {     $o = " --root=${platform_path}" }

is removed...

err: /Stage[main]/Aegir::Dev/Drush::Run[hostmaster-install]/Exec[drush-run:hostmaster-install]/returns: change from notrun to 0 failed: drush @none --yes --debug --working-copy --strict=0 --no-gitinfofile --aegir_version=6.x-2.x --script_user=aegir --aegir_root=/var/aegir --web_group=www-data --aegir_db_port=3306 --http_service_type=apache --aegir_host=aegir2-dev.test --http_port=80 hostmaster-install aegir2-dev.test >> /var/aegir/install.log 2>&1 returned 1 instead of one of [0] at /tmp/vagrant-puppet/modules-0/drush/manifests/run.pp:31

Is there some magic to the 'root' word as option?

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented

Evidently, --root shouldn't be passed by default. What does /var/aegir/install.log say is the problem?

helmo’s picture

helmo commented 
The following settings will be used:
 Aegir frontend URL: aegir2-dev.test
 Master server FQDN: aegir2-dev.test
 Aegir root: /var/aegir
 Aegir user: aegir
 Web group: www-data
 Web server: apache
 Web server port: 80
 Aegir DB host: localhost
 Aegir DB user: root
 Aegir DB password: <previously set>
 Aegir DB port: 3306
 Aegir version: 6.x-2.x
 Aegir platform path: <----- EMPTY
 Admin email: webmaster@aegir2-dev.test
 Aegir makefile: /var/aegir/.drush/provision/aegir.make

It happily starts a drush make with an empty 'Aegir platform path' ... en eventually fails to copy the platform tree inplace. "Destination directory . is not writable. [44.12 sec, 6.14 MB]"

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented

The aegir2-dev test in puppet-aegir isn't passing a '--root' parameter. It's possible that #1635628: do not talk about a makefile if installing over an existing platform may have broken this. But then it's a core issue...

helmo’s picture

helmo commented

I saw that commit while digging into this issue... but don'[t see how it could affect this.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Issue summary: View changes
Status: Active » Postponed (maintainer needs more info)

Is this still an issue with the latest head?

helmo’s picture

helmo commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)

Can't reproduce it at the moment ... closing for now.

  • Commit 7b8182b on 1.0.x by helmo: 
    Issue #2114025 by helmo: Fixed empty --root option for hostmaster-...