The confirm form for restoring defaults uses drupal_goto() - this prevents custom submit handlers from running etc. patch coming up.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

catch’s picture

catch’s picture

Status: Active » Needs review
drumm’s picture

Issue summary: View changes
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

yas’s picture

After applying this patch, hombox gives a white screen by not completing to redirect. In my site, the patch doesn't look working well. I tried to revert to "drupal_goto(homebox_get_path($page));" at my site, and it is still working, though.

yas’s picture

Status: Closed (fixed) » Needs review

Changing the state to "Needs to review".

drumm’s picture

Status: Needs review » Postponed (maintainer needs more info)

What error message did you get in the logs for the white screen. See https://drupal.org/node/158043 for help.

yas’s picture

@drumm,

According to node/158043, I inserted the debug code into index.php but error.log (and access.log) didn't give anything else. It only showed a white screen...

Actually I tried the following system environments by increasing the memory (up to 256M from 128M)

Drupal 7.24 + PHP 5.5.34-0ubuntu0.12.04.1 (Ubuntu 12.04)

and

Drupal 7.24 + PHP 5.5.34-0ubuntu2 (Ubuntu 14.04 dev)

ptsimard’s picture

Hello Drumm,

Just want to add that I too am getting a WSOD when clicking on any links under "Add a block".

There is discrepancy between this issue's title/description and the committed patch:

The patch changed homebox_add_block() instead of homebox_restore_defaults_submit

ptsimard’s picture

Status: Postponed (maintainer needs more info) » Needs review
FileSize
685 bytes

Here is a new patch to revert and fix the correct intended function.

drumm’s picture

Status: Needs review » Fixed

Committed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.