Provide @ConfigEntityType and @ContentEntityType to have better defaults

We should consider to keep maybe the storage controllers on some of the examples in order to show people how to override it.

On the other hand it is really great to simplify the initial work.

This is definitely an improvement, but I dont get why getAnnotationReader is being made public in this patch.

This will need a reroll soon.

Just to ensure I wasn't breaking the ability to do this with #2005716: Promote EntityType to a domain object, I've rerolled this now.

9A is the closest equivalent to a reroll.
9B shows some more options we have with how to deal with the different methods.
9C skips the annotation completely to use the new entity_type_class property directly.

All of these are suffixed with -do-not-test since they won't apply until the other issue goes in.

The c) option with the 'entity_type_class' looks weird - the @ annotation used points at a class, but the actual content of the annotation in fact points to a different (sub)class ?
Why would we go with that rather than a) / b) ?

A and B both contain a \Drupal\Core\Entity\Annotation\EntityType class that have public $entity_type_class = 'Drupal\Core\Config\Entity\ConfigEntityType';

C just skips the middleman.

This is a reroll of B now that the blocker went in.

Silly mistake.

What happened with the ContentEntityType announced in the title?

+++ b/core/lib/Drupal/Core/Config/Entity/ConfigEntityType.php
@@ -0,0 +1,61 @@
+    );
...
+  public function getControllers() {
+    return parent::getControllers() + array(
+      'storage' => 'Drupal\Core\Config\Entity\ConfigStorageController',
...
+  }

Out of scope: Did we ever considered to automatically add the config entity list controller here?

Hah, forgot about that part.

There are 3 entity types that are neither config nor content (extend Entity directly):
FieldUITestNoBundle
EntityCacheTest
MenuLink

Fixing SearchPage.

Rerolled, and made a couple of minor docs tweaks. Let's get this back on the road.

I would like to revive #2004336: Default UUID key in ConfigEntityType.

getControllerClasses() happened.

20: 2119905-20.patch queued for re-testing.

+++ /dev/null
@@ -1,32 +0,0 @@
-  }
...
-    entity_info_cache_clear();
...
-  protected function preDelete($view_modes) {
...
-   */
...
-   * {@inheritdoc}
...
-  /**
...
-  }
...
-    entity_info_cache_clear();
...
-  protected function preSave(EntityInterface $view_mode) {
...
-   */
...
-   * {@inheritdoc}
...
-  /**

Are we sure it is safe deleting this? I don't see this being mentioned anywhere.

Are we sure it is safe deleting this? I don't see this being mentioned anywhere.

Well, these methods aren't used on storage controllers like this anymore, are they?

+++ /dev/null
@@ -1,32 +0,0 @@
-class EntityDisplayModeStorageController extends ConfigStorageController {
-
-  /**
-   * {@inheritdoc}
-   */
-  protected function preSave(EntityInterface $view_mode) {
-    entity_info_cache_clear();
-  }
-
-  /**
-   * {@inheritdoc}
-   */
-  protected function preDelete($view_modes) {
-    entity_info_cache_clear();
-  }

This is dead code, the preSave() and preDelete() have been moved from the storage controller to the entity in #1893772: Move entity-type specific storage logic into entity classes

Looks good, thanks @damiankloip

2119905-20.patch no longer applies.

error: core/modules/entity/lib/Drupal/entity/Entity/EntityDisplay.php: No such file or directory

Rerolled.

Ok, so something like this?

I'm not sure about moving the fieldable stuff, as people could extend from EntityType and not use ContentEntityType but want to use fields etc?

Whoops

Sorry.

Should fail less I think.

This should be it. SORRY.

Nice work.!

Please set back to RTBC once change record is created. Sorry for changing it back to NR.

Added: https://drupal.org/node/2199111

This blocks #2199483: Provide a default config_prefix based on entity type ID and provider which in turn blocks #2080823: Create API to discover config entities' soft dependencies and use this to present a confirm form on module uninstall

Committed b0da3ae and pushed to 8.x. Thanks!

Thanks, this'll be helpful. : )

Some minor things crept in one of the re-rolls. It's just removing a couple of things.

Can we just add this here?

Committed 8b40554 and pushed to 8.x. Thanks!