Looks like this is lingering from the changes in #1903666: Standardize Panelizer submodule naming and placement, where Panelizer was removed from module module's dependencies. However it looks like the commons_groups_directory module still depends on Panelizer (and panels_ipe), despite the fact it doesn't include any settings or variables for panelizer. We should remove these unnecessary dependencies.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | commons_remove_panelizer_groups-2124451-5.patch | 2.04 KB | devin carlson |
| #3 | commons_remove_panelizer_groups-2124451.patch | 1.68 KB | quicksketch |
Comments
Comment #1
ezra-g commentedWe can certainly remove the dependency there, but the default presentation for Group node teasers does use Panelizer, so doing so wouldn't eliminate that dependency from the stack.
Comment #2
ezra-g commentedCorrection: We correctly segmented out the Panelizer config into Commons_groups_pages. So, you are correct that we can remove the dependency and eliminate it from the stack :).
Comment #3
quicksketchOh, hmm. I'll need to look into that more. Here's the starter patch, though features may end up re-adding the dependency on next export.
Comment #4
quicksketchCool, in that case, this is needs review. :)
Comment #5
devin carlson commentedAn updated version of #3 which adds panels_ipe to
commons.info, as commons_groups_directory was the last module which required panels_ipe, so it was no longer enabled during a fresh install of Commons.Comment #6
devin carlson commentedTested #5 with a fresh and an existing Commons install and didn't run into any issues with Commons Groups Directory when Panelizer or the Panels IPE was disabled. I also verified that Panelizer and Panels IPE both continued to be enabled during a fresh install.
Committed #5 to Commons 7.x-3.x.
http://drupalcode.org/project/commons.git/commit/af8ec46
Comment #7
markbannister commentedjust updated commons and OG (OG 7.x-2.4) yesterday and am now getting a fatal error
Call to undefined function ctools_include() in [sitepath]/profiles/commons/modules/contrib/panelizer/panelizer.module on line 526Is this the same issue?
Comment #8
devin carlson commented@markbannister, the patch in #5 only changes which modules must be enabled in order to install the Commons Groups Directory module. It won't have any effect on existing sites.
I'd suggest sticking with the modules included with Commons as they may include required patches. However, if you're still having issues with stock Commons 3.6 or the latest -dev then I'd suggest filing an issue with the Panelizer module.
Comment #9
markbannister commentedDevin: OK, but these are the modules included with Organic Groups (which includes commons) installed in the Commons profile directory by OG.
Don't know a lot about this but it looks like to me panelizer paths/hooks are hosed in my install. If that's the case should I ask at OG or Commons?